[ https://issues.apache.org/jira/browse/IGNITE-8085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471774#comment-16471774 ]
Ivan Fedotov edited comment on IGNITE-8085 at 5/11/18 11:41 AM: ---------------------------------------------------------------- Also I want to clarify what was done in this ticket. Start remote node via ssh has next logic: in StartNodeCallableImpl script [1] to start node and session for this [2] are formed. If info about successful start node was found in logs, ClusterStartNodeResultImpl.isSuccess() returns true, otherwise IgniteException "Remote node could not start. " will be thrown [3]. I suppose that tests failed due to there is not enough time to check logs and although remote node was started, exception is thrown and tests fail. I increase time and iterations for check and tests became green, locally (600 times) and on TC(100 times). I think this fact confirmed my assumption. [1][https://github.com/apache/ignite/blob/master/modules/ssh/src/main/java/org/apache/ignite/internal/util/nodestart/StartNodeCallableImpl.java#L207] [2][https://github.com/apache/ignite/blob/master/modules/ssh/src/main/java/org/apache/ignite/internal/util/nodestart/StartNodeCallableImpl.java#L136] [3][https://github.com/apache/ignite/blob/master/modules/ssh/src/main/java/org/apache/ignite/internal/util/nodestart/StartNodeCallableImpl.java#L285] was (Author: ivanan.fed): Also I want to clarify what was done in this ticket. Start remote node via ssh has next logic: in StartNodeCallableImpl script [1] to start node and session for this [2] are formed. If info about successful start node was found in logs, ClusterStartNodeResultImpl.isSuccess() returns true, otherwise IgniteException "Remote node could not start. " will be thrown [3]. I suppose that tests failed due to there is not enough time to check logs and although remote node was started, exception is thrown and tests fail. I increase time and iterations for check and tests became green, locally (600 times) and on TC(100 times). I think this fact confirmed my assumption. [1][https://github.com/apache/ignite/blob/master/modules/ssh/src/main/java/org/apache/ignite/internal/util/nodestart/StartNodeCallableImpl.java#L207] [2]https://github.com/apache/ignite/blob/master/modules/ssh/src/main/java/org/apache/ignite/internal/util/nodestart/StartNodeCallableImpl.java#L136 [3]https://github.com/apache/ignite/blob/master/modules/ssh/src/main/java/org/apache/ignite/internal/util/nodestart/StartNodeCallableImpl.java#L285 > Flaky failures in Ignite Client Nodes test suite: Remote node could not > start. > -------------------------------------------------------------------------------- > > Key: IGNITE-8085 > URL: https://issues.apache.org/jira/browse/IGNITE-8085 > Project: Ignite > Issue Type: Test > Reporter: Dmitriy Pavlov > Assignee: Ivan Fedotov > Priority: Major > Labels: MakeTeamcityGreenAgain > > Ignite Start Nodes > IgniteStartStopRestartTestSuite: > IgniteProjectionStartStopRestartSelfTest.testStartFiveNodesInTwoCalls (master > fail rate 12,1%) > IgniteStartStopRestartTestSuite: > IgniteProjectionStartStopRestartSelfTest.testStopNodes (master fail rate > 10,1%) > IgniteStartStopRestartTestSuite: > IgniteProjectionStartStopRestartSelfTest.testStopNodesByIds (master fail rate > 10,1%) > https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=6814497542781613621&branch=%3Cdefault%3E&tab=testDetails > https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=1179745277331816127&branch=%3Cdefault%3E&tab=testDetails > https://ci.ignite.apache.org/project.html?projectId=IgniteTests24Java8&testNameId=-842929918974855010&branch=%3Cdefault%3E&tab=testDetails > Test itself is quite old. Last commits were from [~tledkov-gridgain] at 2017. > {noformat} > class org.apache.ignite.IgniteException: Remote node could not start. See log > for details: > /data/teamcity/work/bd85361428dcdb1/work/log/ignite-startNodes/03-29-2018--02-47-24-2003434e.log > at > org.apache.ignite.internal.IgniteProjectionStartStopRestartSelfTest$7.apply(IgniteProjectionStartStopRestartSelfTest.java:388) > at > org.apache.ignite.internal.IgniteProjectionStartStopRestartSelfTest$7.apply(IgniteProjectionStartStopRestartSelfTest.java:383) > at > org.apache.ignite.internal.util.lang.GridFunc.forEach(GridFunc.java:1897) > at > org.apache.ignite.internal.IgniteProjectionStartStopRestartSelfTest.testStartFiveNodesInTwoCalls(IgniteProjectionStartStopRestartSelfTest.java:383) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at junit.framework.TestCase.runTest(TestCase.java:176) > at > org.apache.ignite.testframework.junits.GridAbstractTest.runTestInternal(GridAbstractTest.java:2002) > at > org.apache.ignite.testframework.junits.GridAbstractTest.access$000(GridAbstractTest.java:133) > at > org.apache.ignite.testframework.junits.GridAbstractTest$5.run(GridAbstractTest.java:1917) > at java.lang.Thread.run(Thread.java:745) > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005)