[
https://issues.apache.org/jira/browse/IGNITE-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475483#comment-16475483
]
ASF GitHub Bot commented on IGNITE-8449:
----------------------------------------
GitHub user macrergate opened a pull request:
https://github.com/apache/ignite/pull/3997
IGNITE-8449 no need for checkpoint lock in case of stale updates
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-8449
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/3997.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3997
----
commit 7722dd2d91843f6a84e35d9ed94214dac7bb4809
Author: macrergate <macrergate@...>
Date: 2018-05-12T04:41:07Z
IGNITE-8449 no need for checkpoint lock in case of stale updates
----
> Avoid empty acquiring/releasing checkpointReadLock for stale updates
> --------------------------------------------------------------------
>
> Key: IGNITE-8449
> URL: https://issues.apache.org/jira/browse/IGNITE-8449
> Project: Ignite
> Issue Type: Bug
> Reporter: Sergey Kosarev
> Assignee: Sergey Kosarev
> Priority: Major
>
> we have in
> org.apache.ignite.internal.processors.cache.distributed.dht.GridDhtPartitionTopologyImpl#update(org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionExchangeId,
>
> org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionMap,
> boolean)
> currently we have something like this
> {code:java}
> ctx.database().checkpointReadLock();
> try {
> .......
> if (isStaleUpdate(cur, parts)) {
> ....
> return false;
> }
> .....
> }
> finally {
> ctx.database().checkpointReadUnlock();
> }
> {code}
> we'd better do not accquire those lock for isStaleUpdate == true branch. It
> can significantly decrease contention as this method can be hot (thousands
> invocations per minute) see also IGNITE-8226
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
