[ https://issues.apache.org/jira/browse/IGNITE-5011?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478457#comment-16478457 ]
Vasiliy Sisko edited comment on IGNITE-5011 at 5/17/18 3:36 AM: ---------------------------------------------------------------- Looks good. [~pkonstantinov] Please test with empty and invalid arguments. Check validation of other arguments. Also check validation of -t argument for events command. was (Author: vsisko): Looks good. [~pkonstantinov] Please test with empty and invalid arguments. Check validation of other arguments. > Add validation of input params of disco command > ----------------------------------------------- > > Key: IGNITE-5011 > URL: https://issues.apache.org/jira/browse/IGNITE-5011 > Project: Ignite > Issue Type: Bug > Reporter: Pavel Konstantinov > Assignee: Wuwei Lin > Priority: Trivial > > {code} > visor> disco -t=0h > java.lang.IllegalArgumentException: Time frame size is not positive in: 0h > at org.apache.ignite.visor.visor$.timeFilter(visor.scala:2671) > at > org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand.disco(VisorDiscoveryCommand.scala:127) > at > org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282) > at > org.apache.ignite.visor.commands.disco.VisorDiscoveryCommand$$anonfun$4.apply(VisorDiscoveryCommand.scala:282) > at > org.apache.ignite.visor.commands.VisorConsole.mainLoop(VisorConsole.scala:217) > at > org.apache.ignite.visor.commands.VisorConsole$.delayedEndpoint$org$apache$ignite$visor$commands$VisorConsole$1(VisorConsole.scala:329) > at > org.apache.ignite.visor.commands.VisorConsole$delayedInit$body.apply(VisorConsole.scala:318) > at scala.Function0$class.apply$mcV$sp(Function0.scala:34) > at > scala.runtime.AbstractFunction0.apply$mcV$sp(AbstractFunction0.scala:12) > at scala.App$$anonfun$main$1.apply(App.scala:76) > at scala.App$$anonfun$main$1.apply(App.scala:76) > at scala.collection.immutable.List.foreach(List.scala:381) > at > scala.collection.generic.TraversableForwarder$class.foreach(TraversableForwarder.scala:35) > at scala.App$class.main(App.scala:76) > at > org.apache.ignite.visor.commands.VisorConsole$.main(VisorConsole.scala:318) > at > org.apache.ignite.visor.commands.VisorConsole.main(VisorConsole.scala) > (wrn) <visor>: Invalid command name: 'disco -t=0h' > (wrn) <visor>: Type 'help' to print commands list. > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)