[ https://issues.apache.org/jira/browse/IGNITE-8603?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16494019#comment-16494019 ]
Ivan Rakov commented on IGNITE-8603: ------------------------------------ [~dgladkikh], some comments: 1. Code style 1.1. #getTotalBaselineNodes and #getActiveBaselineNodes in ClusterLocalNodeMetricsMXBeanImpl class lack {@inheritDoc} 1.2. Semantic units of #getTotalBaselineNodes body should be separated by blank lines - check "Whitespaces and empty lines" section of https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines 1.3. One-liner in #getTotalBaselineNodes body shouldn't be enclosed in curly braces, see "Braces and Identation" section 1.4. Points 1.2 and 1.3 relate to ClusterMetricsMXBeanImpl as well 2. I think, it would be good to add test case when non-baseline server node is present in the cluster 3. ClusterBaselineNodesMetricsSelfTest is not included in any test suite 4. Please schedule Run All on public TeamCity and attach link here > Add JMX-metric to cluster: baseline nodes > ----------------------------------------- > > Key: IGNITE-8603 > URL: https://issues.apache.org/jira/browse/IGNITE-8603 > Project: Ignite > Issue Type: Improvement > Reporter: Dmitriy Gladkikh > Assignee: Dmitriy Gladkikh > Priority: Major > Fix For: 2.6 > > > Need to add a baseline nodes on JMX: > {code:java} > int org.apache.ignite.mxbean.ClusterMetricsMXBean#getTotalBaselineNodes > int org.apache.ignite.mxbean.ClusterMetricsMXBean#getActiveBaselineNodes > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)