[jira] [Updated] (IGNITE-8661) WALItreater is not stopped if can not deserialize record

[Dmitriy Govorukhin (JIRA)]

     [ 
https://issues.apache.org/jira/browse/IGNITE-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dmitriy Govorukhin updated IGNITE-8661:
---------------------------------------
    Description: 
RecordV1Serializer.readWithCrc
{code:java}
static WALRecord readWithCrc(.....) throws EOFException, IgniteCheckedException 
{
  
    try (FileInput.Crc32CheckingFileInput in = in0.startRead(skipCrc)) {
      ..... 
    }
    catch (EOFException | SegmentEofException | WalSegmentTailReachedException 
e) {
        throw e;
    }
    catch (Exception e) {
        throw new IgniteCheckedException("Failed to read WAL record at 
position: " + startPos, e);
    }
}
{code}

Any runtime error will be remap to IgniteCheckedException 

AbstractWalRecordsIterator.advanceRecord

{code}
   try {
         ......
        }
        catch (IOException | IgniteCheckedException e) {
            if (e instanceof WalSegmentTailReachedException)
                throw (WalSegmentTailReachedException)e;

            if (!(e instanceof SegmentEofException))
                handleRecordException(e, actualFilePtr);

            return null;
        }
{code}

Any IgniteCheckedException will be ignored and iterator go ahead to the next 
segment.

  was:
RecordV1Serializer.readWithCrc
{code:java}
static WALRecord readWithCrc(.....) throws EOFException, IgniteCheckedException 
{
  
    try (FileInput.Crc32CheckingFileInput in = in0.startRead(skipCrc)) {
      ..... 
    }
    catch (EOFException | SegmentEofException | WalSegmentTailReachedException 
e) {
        throw e;
    }
    catch (Exception e) {
        throw new IgniteCheckedException("Failed to read WAL record at 
position: " + startPos, e);
    }
}
{code}

Any runtime error will be remap to IgniteCheckedException 


> WALItreater is not stopped if can not deserialize record 
> ---------------------------------------------------------
>
>                 Key: IGNITE-8661
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8661
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Dmitriy Govorukhin
>            Priority: Major
>
> RecordV1Serializer.readWithCrc
> {code:java}
> static WALRecord readWithCrc(.....) throws EOFException, 
> IgniteCheckedException {
>   
>     try (FileInput.Crc32CheckingFileInput in = in0.startRead(skipCrc)) {
>       ..... 
>     }
>     catch (EOFException | SegmentEofException | 
> WalSegmentTailReachedException e) {
>         throw e;
>     }
>     catch (Exception e) {
>         throw new IgniteCheckedException("Failed to read WAL record at 
> position: " + startPos, e);
>     }
> }
> {code}
> Any runtime error will be remap to IgniteCheckedException 
> AbstractWalRecordsIterator.advanceRecord
> {code}
>    try {
>          ......
>         }
>         catch (IOException | IgniteCheckedException e) {
>             if (e instanceof WalSegmentTailReachedException)
>                 throw (WalSegmentTailReachedException)e;
>             if (!(e instanceof SegmentEofException))
>                 handleRecordException(e, actualFilePtr);
>             return null;
>         }
> {code}
> Any IgniteCheckedException will be ignored and iterator go ahead to the next 
> segment.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)