[ 
https://issues.apache.org/jira/browse/IGNITE-8673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eduard Shangareev updated IGNITE-8673:
--------------------------------------
    Description: 
Now isClient (Mode, Cache and so on) methods semantic could mean different 
things:
-the same as IgniteConfiguration#setClientMode;
-or the way how a node is connected to cluster (in the ring or not).

Almost in all cases, we need the first thing, but actually methods could return 
second.
For example, ClusterNode.isClient means second, but all of us use as first.

So, I propose to make all methods return first.
And if there are places which require second replace them with the usage of 
forceClientMode.

  was:
Now isClient (Mode, Cache and so on) method semantic could mean different 
things:
-the same as IgniteConfiguration#setClientMode;
-or the way how a node is connected to cluster (in the ring or not).

Almost in all cases, we need the first thing, but actually methods could return 
second.
For example, ClusterNode.isClient means second, but all of us use as first.

So, I propose to make all methods return first.
And if there are places which require second replace them with the usage of 
forceClientMode.


> Reconcile isClient* methods
> ---------------------------
>
>                 Key: IGNITE-8673
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8673
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Eduard Shangareev
>            Assignee: Eduard Shangareev
>            Priority: Critical
>             Fix For: 2.6
>
>
> Now isClient (Mode, Cache and so on) methods semantic could mean different 
> things:
> -the same as IgniteConfiguration#setClientMode;
> -or the way how a node is connected to cluster (in the ring or not).
> Almost in all cases, we need the first thing, but actually methods could 
> return second.
> For example, ClusterNode.isClient means second, but all of us use as first.
> So, I propose to make all methods return first.
> And if there are places which require second replace them with the usage of 
> forceClientMode.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to