[ 
https://issues.apache.org/jira/browse/IGNITE-8183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16500063#comment-16500063
 ] 

Sergey Chugunov commented on IGNITE-8183:
-----------------------------------------

[~garus.d.g], thanks for your patch!

Your analysis seems correct to me. It looks like that the source of the 
original timeout of 20 seconds could be value of syncLimit which is always 
configured to 5 in testing cluster.

However I don't think we should add up sesTimeout on ZookeeperClient side, sum 
of tickTime * initLimit + otherLogic should be enough here.

Also I left a comment in your PR, please address it and we will be good to 
proceed.

> ZookeeperDiscoverySpiTest#testSegmentation3 fails on TC and locally
> -------------------------------------------------------------------
>
>                 Key: IGNITE-8183
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8183
>             Project: Ignite
>          Issue Type: Bug
>          Components: zookeeper
>            Reporter: Sergey Chugunov
>            Assignee: Denis Garus
>            Priority: Major
>              Labels: MakeTeamcityGreenAgain
>
> Test fails with assertion on awaits on latch:
> {noformat}
> junit.framework.AssertionFailedError
>     at junit.framework.Assert.fail(Assert.java:55)
>     at junit.framework.Assert.assertTrue(Assert.java:22)
>     at junit.framework.Assert.assertTrue(Assert.java:31)
>     at junit.framework.TestCase.assertTrue(TestCase.java:201)
>     at 
> org.apache.ignite.spi.discovery.zk.internal.ZookeeperDiscoverySpiTest.testSegmentation3(ZookeeperDiscoverySpiTest.java:1060)
>     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>     at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>     at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>     at java.lang.reflect.Method.invoke(Method.java:498)
>     at junit.framework.TestCase.runTest(TestCase.java:176)
>     at 
> org.apache.ignite.testframework.junits.GridAbstractTest.runTestInternal(GridAbstractTest.java:2080)
>     at 
> org.apache.ignite.testframework.junits.GridAbstractTest.access$000(GridAbstractTest.java:140)
>     at 
> org.apache.ignite.testframework.junits.GridAbstractTest$5.run(GridAbstractTest.java:1995)
>     at java.lang.Thread.run(Thread.java:748)
> {noformat}
> For some reason SEGMENTATION event is never fired, so assertion on latch 
> fails. Investigation is needed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to