[ 
https://issues.apache.org/jira/browse/IGNITE-8922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16545117#comment-16545117
 ] 

Dmitry Karachentsev commented on IGNITE-8922:
---------------------------------------------

[~dmekhanikov] in general it looks fine, but node is vulnerable for OOME or 
IllegalStateException, because pending message queue could grow unlimited now. 
Anyway, both cases: node hang due to lost messages or OOME are harmful, but 
last is less possible. I'm OK with this change so far.

> Discovery message delivery guarantee can be violated
> ----------------------------------------------------
>
>                 Key: IGNITE-8922
>                 URL: https://issues.apache.org/jira/browse/IGNITE-8922
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.5
>            Reporter: Denis Mekhanikov
>            Assignee: Denis Mekhanikov
>            Priority: Critical
>             Fix For: 2.7
>
>         Attachments: PendingMessageResendTest.java
>
>
> Under certain circumstances discovery messages may be delivered only to a 
> part of nodes.
> It happens because pending messages are not resent due to data inconsistency 
> in {{ServerImpl#PendingMessages}} class. If {{discardId}} or 
> {{customDiscardId}} point to a message, that is not present in the queue, 
> then other messages will be skipped and won't be resent. It may happen, for 
> example, when queue in {{PendingMessages}} is overflown.
> PFA test, that reproduces this problem.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to