[
https://issues.apache.org/jira/browse/IGNITE-9627?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16620322#comment-16620322
]
Amelchev Nikita commented on IGNITE-9627:
-----------------------------------------
*The test can halt JVM.*
I have rewritten test to avoid use default failure handler.
*The test was flaky.*
I set segmentation policy to NOOP (was STOP) in config. Default handler stops
node on segmentation happens in the test. The local listener couldn't get the
event if segmentation failure handles first.
*Other fixes.*
I have decreased timeouts and removed unnecessary sleeps for more fast test
completion. It still reproduces the problem that fixed in IGNITE-7944 if revert
prod changes.
Code style issues.
[TC
tests|https://ci.ignite.apache.org/viewType.html?buildTypeId=IgniteTests24Java8_Spi&branch_IgniteTests24Java8=pull%2F4790%2Fhead&tab=buildTypeStatusDiv]
are OK. I have run 160 times and test separate suite.
[~agoncharuk] Could you review, please?
> TcpCommunicationSpiSkipMessageSendTest.testClientSegmented is flaky in master
> -----------------------------------------------------------------------------
>
> Key: IGNITE-9627
> URL: https://issues.apache.org/jira/browse/IGNITE-9627
> Project: Ignite
> Issue Type: Bug
> Reporter: Amelchev Nikita
> Assignee: Amelchev Nikita
> Priority: Major
> Labels: MakeTeamcityGreenAgain
> Fix For: 2.7
>
>
> The test is flaky in master. Also, it uses the default failure handler and
> can halt JVM.
> Example of fail: [TC
> build|https://ci.ignite.apache.org/viewLog.html?buildId=1895268&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_Spi#testNameId-3225493048753223945].
> Log:
> {noformat}
> [2018-09-18 06:12:42,466][ERROR][main][root] Test failed.
> junit.framework.AssertionFailedError: Client wasn't segmented.
> at junit.framework.Assert.fail(Assert.java:57)
> at junit.framework.TestCase.fail(TestCase.java:227)
> at
> org.apache.ignite.spi.communication.tcp.TcpCommunicationSpiSkipMessageSendTest.testClientSegmented(TcpCommunicationSpiSkipMessageSendTest.java:104)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at junit.framework.TestCase.runTest(TestCase.java:176)
> at
> org.apache.ignite.testframework.junits.GridAbstractTest.runTestInternal(GridAbstractTest.java:2177)
> at
> org.apache.ignite.testframework.junits.GridAbstractTest.access$000(GridAbstractTest.java:143)
> at
> org.apache.ignite.testframework.junits.GridAbstractTest$5.run(GridAbstractTest.java:2092)
> at java.lang.Thread.run(Thread.java:748)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
