[ https://issues.apache.org/jira/browse/IGNITE-9272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631338#comment-16631338 ]
Nikolay Izhikov commented on IGNITE-9272: ----------------------------------------- Hello [~zstan] I have done the review. Please, take a look at my comments in PR > PureJavaCrc32 vs j.u.zip.CRC32 benchmark and probably replace. > -------------------------------------------------------------- > > Key: IGNITE-9272 > URL: https://issues.apache.org/jira/browse/IGNITE-9272 > Project: Ignite > Issue Type: Improvement > Components: general > Affects Versions: 2.6 > Reporter: Stanilovsky Evgeny > Assignee: Stanilovsky Evgeny > Priority: Major > Fix For: 2.7 > > Attachments: BenchmarkCRC.java > > > I see that Ignite has its own crc32 realization called: PureJavaCrc32 and > from desc it seems to be : _The current version is ~10x to 1.8x as fast as > Sun's native java.util.zip.CRC32 in Java 1.6_ But my jmh tests show opposite > results. > + If it really so, looks like backward compatibility would be easy, all that > need is just to take lower part of long form zip.crc32 realization. > jmh results: > Benchmark Mode Cnt Score Error Units > BenchmarkCRC.Crc32 avgt 5 1521060.716 ± 44083.424 ns/op > BenchmarkCRC.pureJavaCrc32 avgt 5 4657756.671 ± 177243.254 ns/op > JMH version: 1.21 > VM version: JDK 1.8.0_131, Java HotSpot(TM) 64-Bit Server VM, 25.131-b11 > VM invoker: /usr/lib/jvm/java-8-oracle/jre/bin/java > op system : ubuntu 16.10 -- This message was sent by Atlassian JIRA (v7.6.3#76005)