[ https://issues.apache.org/jira/browse/IGNITE-9935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656485#comment-16656485 ]
ASF GitHub Bot commented on IGNITE-9935: ---------------------------------------- GitHub user xtern opened a pull request: https://github.com/apache/ignite/pull/5032 IGNITE-9935 Test fix. You can merge this pull request into a Git repository by running: $ git pull https://github.com/xtern/ignite IGNITE-9935 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5032.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5032 ---- commit bff90beb6d7dd594118473dbcad1a2379402fdd8 Author: pereslegin-pa <xxtern@...> Date: 2018-10-19T08:59:23Z IGNITE-9935 Test fix. ---- > [Test Failed] > GridCacheBinaryObjectMetadataExchangeMultinodeTest.testReadRequestBlockedOnUpdatingMetadata > flaky fails on TC. > ---------------------------------------------------------------------------------------------------------------------------- > > Key: IGNITE-9935 > URL: https://issues.apache.org/jira/browse/IGNITE-9935 > Project: Ignite > Issue Type: Bug > Affects Versions: 2.6 > Reporter: Pavel Pereslegin > Assignee: Pavel Pereslegin > Priority: Major > Labels: MakeTeamcityGreenAgain > Fix For: 2.8 > > > GridCacheBinaryObjectMetadataExchangeMultinodeTest.testReadRequestBlockedOnUpdatingMetadata > fails sometimes on master branch. > Example of recent failure on TC: > https://ci.ignite.apache.org/viewLog.html?buildId=2103824&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_BinaryObjects#testNameId8753246349372607337 > Typical log output: > {noformat} > junit.framework.AssertionFailedError: unexpected size of syncMap: > expected:<1> but was:<0> > at junit.framework.Assert.fail(Assert.java:57) > at junit.framework.Assert.failNotEquals(Assert.java:329) > at junit.framework.Assert.assertEquals(Assert.java:78) > at junit.framework.Assert.assertEquals(Assert.java:234) > at junit.framework.TestCase.assertEquals(TestCase.java:401) > at > org.apache.ignite.internal.processors.cache.binary.GridCacheBinaryObjectMetadataExchangeMultinodeTest$3.handleDiscoveryMessage(GridCacheBinaryObjectMetadataExchangeMultinodeTest.java:198) > at > org.apache.ignite.testframework.GridTestUtils$DiscoverySpiListenerWrapper.onDiscovery(GridTestUtils.java:165) > at > org.apache.ignite.spi.discovery.tcp.ServerImpl$RingMessageWorker.notifyDiscoveryListener(ServerImpl.java:5642) > at > org.apache.ignite.spi.discovery.tcp.ServerImpl$RingMessageWorker.processCustomMessage(ServerImpl.java:5521) > at > org.apache.ignite.spi.discovery.tcp.ServerImpl$RingMessageWorker.processMessage(ServerImpl.java:2837) > at > org.apache.ignite.spi.discovery.tcp.ServerImpl$RingMessageWorker.processMessage(ServerImpl.java:2611) > at > org.apache.ignite.spi.discovery.tcp.ServerImpl$MessageWorker.body(ServerImpl.java:7188) > at > org.apache.ignite.spi.discovery.tcp.ServerImpl$RingMessageWorker.body(ServerImpl.java:2700) > at > org.apache.ignite.internal.util.worker.GridWorker.run(GridWorker.java:120) > at > org.apache.ignite.spi.discovery.tcp.ServerImpl$MessageWorkerThread.body(ServerImpl.java:7119) > at org.apache.ignite.spi.IgniteSpiThread.run(IgniteSpiThread.java:62) > {noformat} > It seems there are two issues in this test: > 1. executorService used without arguments - the task can be executed on a > random node instead of the specified one. > 2. not stable synchronization between "proposed" message processing and > metadata reading. -- This message was sent by Atlassian JIRA (v7.6.3#76005)