[ 
https://issues.apache.org/jira/browse/IGNITE-9010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16660859#comment-16660859
 ] 

Ilya Murchenko commented on IGNITE-9010:
----------------------------------------

Hi [~vveider], I've checked your PR and I have a few comments:
 # There is a typo in line 49 [1], the correct key for apt command is 
"--no-install-recommends"
 # "node:8-slim" image is using the old version of Debian jessie as a **base 
image and doesn't have "apt clean" command [2]. It should be changed by 
"apt-get clean" command.

 

[1] 
[https://github.com/apache/ignite/pull/4528/commits/761e746e0c4e3d1c01ec6481311d20de14d87c02#diff-f006d67e8df98048b58850d4957a65afR49]

[2] 
https://github.com/apache/ignite/pull/4528/commits/761e746e0c4e3d1c01ec6481311d20de14d87c02#diff-f006d67e8df98048b58850d4957a65afR53

> Move web-console build to dedicated root directory
> --------------------------------------------------
>
>                 Key: IGNITE-9010
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9010
>             Project: Ignite
>          Issue Type: Task
>            Reporter: Peter Ivanov
>            Assignee: Ilya Murchenko
>            Priority: Major
>
> # Move web-console docker image build (web-console, frontend and backend) to 
> {{/docker}} directory.
> # Prepare README.md file in root of {{/docker}} directory with instructions 
> on how to build corresponding image. Remove obsolete per-image README's from 
> Dockerfile directories.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to