[
https://issues.apache.org/jira/browse/IGNITE-10493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723137#comment-16723137
]
ASF GitHub Bot commented on IGNITE-10493:
-----------------------------------------
GitHub user Jokser opened a pull request:
https://github.com/apache/ignite/pull/5688
IGNITE-10493 Refactor exchange timings
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gridgain/apache-ignite ignite-10493
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ignite/pull/5688.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5688
----
commit 11bab06240ca9dae34d1b108f45f374feae08348
Author: Pavel Kovalenko <jokserfn@...>
Date: 2018-12-03T18:18:16Z
IGNITE-10493 WIP
Signed-off-by: Pavel Kovalenko <jokse...@gmail.com>
commit f9bf25cea24fbc40fe0cb5b7326a485b2afbfee0
Author: Pavel Kovalenko <jokserfn@...>
Date: 2018-12-12T10:10:59Z
IGNITE-10493 WIP
Signed-off-by: Pavel Kovalenko <jokse...@gmail.com>
commit a3ad16f63b2b11ccb829b1468339a759a776a21e
Author: Pavel Kovalenko <jokserfn@...>
Date: 2018-12-17T16:36:53Z
IGNITE-10493 Refactor exchange timings.
Signed-off-by: Pavel Kovalenko <jokse...@gmail.com>
----
> Refactor exchange stages time measurements
> ------------------------------------------
>
> Key: IGNITE-10493
> URL: https://issues.apache.org/jira/browse/IGNITE-10493
> Project: Ignite
> Issue Type: Improvement
> Components: cache
> Affects Versions: 2.7
> Reporter: Pavel Kovalenko
> Assignee: Pavel Kovalenko
> Priority: Major
> Fix For: 2.8
>
>
> At the current implementation, we don't cover and measure all possible code
> executions that influence on PME time. Instead of it we just measure the
> hottest separate parts with the following hardcoded pattern:
> {noformat}
> long time = currentTime();
> ... // some code block
> print ("Stage name performed in " + (currentTime() - time));
> {noformat}
> This approach can be improved. Instead of declaring time variable and print
> the message to log immediately we can introduce a utility class (TimesBag)
> that will hold all stages and their times. The content of TimesBag can be
> printed when the exchange future is done.
> As exchange is a linear process that executes init stage by exchange-worker
> and finish stage by one of the sys thread we can easily cover all exchange
> code base by time cutoffs.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
