[ https://issues.apache.org/jira/browse/IGNITE-10727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16726734#comment-16726734 ]
ASF GitHub Bot commented on IGNITE-10727: ----------------------------------------- GitHub user dmitrievanthony opened a pull request: https://github.com/apache/ignite/pull/5723 IGNITE-10727: InfModel and Model merging You can merge this pull request into a Git repository by running: $ git pull https://github.com/gridgain/apache-ignite ignite-10727 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/ignite/pull/5723.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #5723 ---- commit 1991fea7d9f83f78f4accb62aacfc8f81406febe Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-11-29T13:38:18Z IGNITE-10289: First version of XGBoost model parser. commit e23241ee42146b98140f8071f300fd37c6ce7c01 Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-11-29T15:51:38Z IGNITE-10289: Add licence header into XGBoostModel.g4. commit 4b004fc6b8400f70d7b4665c488602abf524f827 Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-11-29T16:11:28Z IGNITE-10289: Add example for XGBoostModelParser. commit ec4efd2e736f4fcad5db553cb3eee47e74656295 Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-11-30T09:45:12Z IGNITE-10289: Fix queue issue in IgniteDistributedInfModelBuilder. commit b95dee0029ffa60565bd8068c8e2bd610025461a Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-11-30T09:55:13Z IGNITE-10289: Exclude model files from licence check scope. commit a36537d3ba0ee733a5c678f5dc9adf8334e1d577 Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-11-30T15:49:25Z IGNITE-10289: Update TensorFlow examples after move models into models directory. commit b2822c861066e36b5c3e620f9ffa601190cdaed6 Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-17T09:17:38Z IGNITE-10289: Move XGBoost lexer/parser generated by ANTLR into source tree. commit db03e38f398729c3efa9c12cb5e9537c3d2dc50c Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-17T09:21:15Z Merge branch 'master' into ignite-10289 commit 10dea555a7edaa8e4af53c81c9b7a9838d2361b6 Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-17T09:28:43Z IGNITE-10289: Add test suite into xgboost-model-parser module. commit fcbe24710eb0b432dd563b6267c74ae40dbdc502 Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-17T09:31:19Z IGNITE-10289: Revert changes in example-default.xml. commit 4c7d5e2c7ddf8709b8465f4db53737f40e33e416 Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-17T11:37:01Z IGNITE-10289: Fix TC errors. commit a8a07dac6ea6ea2379990ac3f6b2614d22b7b3b3 Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-17T12:26:52Z IGNITE-10289: Fix TC errors and add ANTLR grammar into javadoc commit 8adbb6d90f0d47cd27a2bc4bd1539f8fada15676 Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-17T14:18:33Z IGNITE-10289: Add todo, merge XGBoost and Ignite ML trees together. commit d7da5b4c43e43b890de358bea40c73378a01c40f Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-17T16:13:54Z Merge remote-tracking branch 'origin/master' into ignite-10289 commit 33fa5b010dc60719b4adaa363eb56b62fb0ce373 Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-18T13:04:55Z IGNITE-10718: Replace XGBoost trees by Ignite ML trees, initial version. commit e585f5f98179ba8d771cc07e352904f2ae082145 Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-18T15:38:16Z Merge branch 'master' into ignite-10718 # Conflicts: # examples/src/main/java/org/apache/ignite/examples/ml/xgboost/XGBoostModelParserExample.java # modules/ml/xgboost-model-parser/src/main/java/org/apache/ignite/ml/xgboost/parser/XGModelParser.java # modules/ml/xgboost-model-parser/src/main/java/org/apache/ignite/ml/xgboost/parser/visitor/XGModelVisitor.java # modules/ml/xgboost-model-parser/src/main/java/org/apache/ignite/ml/xgboost/parser/visitor/XGTreeVisitor.java # modules/ml/xgboost-model-parser/src/test/java/org/apache/ignite/ml/xgboost/parser/XGBoostModelParserTest.java commit 3c3258a835b3c4ee6b2924bcb01e0299d3bdbabc Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-18T15:53:35Z IGNITE-10718: Fixes after merge. commit 9fbbf2642024246ad79464eeedeb0ba4fced134f Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-19T09:41:02Z IGNITE-10718: Fix min max scaler. commit d80c80cfb70e2f71c63f22ed926bb1652728e7b3 Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-19T10:12:32Z IGNITE-10718: Fix ML model hierarchy. commit cbd7f995bf9da894e0ef02501d5b2271811ae060 Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-19T13:32:55Z IGNITE-10718: Fix exception in Step_1_Read_and_Learn. commit 21b70ac09264dac5bcd434e32096d8b1a1dbc26b Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-19T13:52:44Z IGNITE-10718: Fix exception in Step_1_Read_and_Learn. commit 177255400b2796f5c6dfd6c4d452406d7295a6fb Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-20T12:12:25Z IGNITE-10718: Fixes after review. commit af8912fbb17241c7250b8e8630b188050912ed5d Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-20T12:31:32Z IGNITE-10718: Fixes after review. commit e504efbdd2a854892135e4a9ccf1e20c2e7d3cb9 Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-20T12:35:30Z IGNITE-10718: Fixes after review. commit 6810fd903c49eabf6d82fb531c86193f310cf859 Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-20T12:54:52Z IGNITE-10718: Fixes after review. commit c693469e1075f7cab9513641c6a54a1d8f449f4a Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-21T11:21:56Z Merge branch 'master' into ignite-10718 commit 464969a5b49de72f03cd9737f6d70d0f1ab8fb02 Author: dmitrievanthony <dmitrievanthony@...> Date: 2018-12-21T13:25:01Z IGNITE-10727: Rename s/Model/IgniteModel, s/InfModel/Model, s/apply()/predict(). ---- > [ML] InfModel and Model merging > -------------------------------- > > Key: IGNITE-10727 > URL: https://issues.apache.org/jira/browse/IGNITE-10727 > Project: Ignite > Issue Type: Improvement > Components: ml > Reporter: Alexey Platonov > Assignee: Anton Dmitriev > Priority: Major > Fix For: 2.8 > > > Currently "InfModel" and "Model" provide parallel architecture in terms of > using of "InfModels" in after-learning steps like compositions, estimations > etc. I propose to move "InfModel" to top of models hierarchy and rename it to > just "Model" and current "Model" rename to > "LearnedModel/LocalModel/Your_ad_may_be_here". So in this way "InfModel" will > be just model with apply-function for generic I-O values and "Model" will be > serializable thing on Vector-Double. -- This message was sent by Atlassian JIRA (v7.6.3#76005)