[ https://issues.apache.org/jira/browse/IGNITE-10748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16760581#comment-16760581 ]
Maxim Muzafarov commented on IGNITE-10748: ------------------------------------------ [~sergey-chugunov] Thank you for the review! I've fixed all your comments except one (mentioned in PR). I think we should leave the {{safeTcpHandshake}} method as it is to avoid huge PR changes. But, in general, you're right. Please, share your thoughts. > Remove dead code in TcpCommunicationSpi for the tcp client creation flow > ------------------------------------------------------------------------ > > Key: IGNITE-10748 > URL: https://issues.apache.org/jira/browse/IGNITE-10748 > Project: Ignite > Issue Type: Task > Reporter: Maxim Muzafarov > Assignee: Maxim Muzafarov > Priority: Minor > Fix For: 2.8 > > Time Spent: 1.5h > Remaining Estimate: 0h > > Currently, a batch of changes can be applied over {{TcpCommunicationSpi}} > class implementation due to: > # {{safeTcpHandshake(..)}} > #* {{handshakeConnIdx}} - parameter is always not null > #* {{recovery}} - parameter is always not null > #* {{HandhakeMessage}} - is not used in current flow at all > # {{HandshakeMessage2}} > #* Message size must be defined in the message class as constant > # {{createTcpClient(..)}} > #* Instantiation of {{GridTcpNioCommunicationClient}} must be performed > outside the while-loop > # Code-style issues. Fix one-liner if statements. > # Extract internal {{HandshakeException}}, {{HandshakeTimeoutException}} from > class. -- This message was sent by Atlassian JIRA (v7.6.3#76005)