[
https://issues.apache.org/jira/browse/IGNITE-11226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16809240#comment-16809240
]
Pavel Kuznetsov commented on IGNITE-11226:
------------------------------------------
[~vozerov] Ok I've updated patch according to your comments
p2: Thanks, I forgot to update method signatures in the interface, fixed that.
Actually, in the methods themselves, we don't throw any exceptions, we rely on
the validation performed in the parser, which already sets
{{IgniteQueryErrorCode}} s. Should we catch them in the indexing and re-throw
with some other code?
p3: hm. Ok, I switched to {{IgniteCheckedException}} it means we hide original
reason (which is thrown by h2) from user. Is it ok?
> SQL: Remove GridQueryIndexing.prepareNativeStatement
> ----------------------------------------------------
>
> Key: IGNITE-11226
> URL: https://issues.apache.org/jira/browse/IGNITE-11226
> Project: Ignite
> Issue Type: Task
> Components: sql
> Reporter: Vladimir Ozerov
> Assignee: Pavel Kuznetsov
> Priority: Major
> Fix For: 2.8
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This method is the only leak of H2 internals to the outer code. Close
> analysis of code reveals that the only reason we have it is *JDBC metadata*.
> Need to create a method which will prepare metadata for a statement and
> return it as a detached object. Most probably we already have all necessary
> mechanics. This is more about refactoring.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
