[ 
https://issues.apache.org/jira/browse/IGNITE-11708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816001#comment-16816001
 ] 

Ivan Pavlukhin commented on IGNITE-11708:
-----------------------------------------

[~ivanan.fed], yes it seems that it is hard to be sure that all tests methods 
were executed. For example, in junit 4 is simple to skip all test methods but 
having all them as passed in report with a _rule_ that does not _evaluate base 
statement_. Perhaps, we can find some ideas in the Internet. I think we can 
tackle with writing a special test extending 
_IgniteConfigVariationsAbstractTest_ checking in _after class_ callback that a 
test method (or couple of methods and perhaps other before/after callbacks) 
were executed. Schematically, it is:
{code}
public class VariationExecutionTest extends IgniteConfigVariationsAbstractTest {
  private boolean testExecuted = false;

  @AfterClass
  public void validate() {
    assertTrue(testExecuted);
  }

  @Test
  public void test() {
    testExecuted = true;
  }
}
{code}

Also I have a comment about _rules_ execution order. It seems that when we have 
a {{RuleChain}} annotated with a {{@Rule}} annotaiton which includes another 
rule (let's is is _ruleA_) annotated with {{@Rule}} then _ruleA_ will be 
executed twice. And it does not look desired. First we should look for common 
best practice how to solve it.

Also it is still unclear and quite interesting why all _variation_ test methods 
are skipped. Please write back once you find a clue.

> Unable to run tests in IgniteConfigVariationsAbstractTest subclasses
> --------------------------------------------------------------------
>
>                 Key: IGNITE-11708
>                 URL: https://issues.apache.org/jira/browse/IGNITE-11708
>             Project: Ignite
>          Issue Type: Bug
>            Reporter: Ivan Fedotov
>            Assignee: Ivan Fedotov
>            Priority: Major
>              Labels: iep30
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> It seems that test classes that extend from 
> IgniteConfigVariationsAbstractTest cannot be started with JUnit4 @Test 
> annotation. 
> It is easy to check: if throw exception in any test methods, nothing will 
> happen.
> Reason can be in rule chain in IgniteConfigVariationsAbstractTest class [1], 
> maybe it destroys existing test workflow.
> [1] 
> https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java#L62



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to