[
https://issues.apache.org/jira/browse/IGNITE-11708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16850028#comment-16850028
]
Ivan Fedotov edited comment on IGNITE-11708 at 5/28/19 6:44 PM:
----------------------------------------------------------------
[~Pavlukhin], I removed the garbage injection and left only one non-static cfg
variable.
Moreover, I assigned configuration directly before each test (and
beforeTestsStarted method) with reflection instead of injectTestsConfiguration
method invocation [1].
I think now it looks better and without unnecessary actions.
Also, I removed double stopAllGrids (I don't know why it's necessary to invoke
it twice - because of this Cache tests were broken) [2].
I checked RunAllNightly and new failures seem for me from the first view not
because of test workflow, but because of real reasons.
Could you take a look at such solution, please?
[1]https://github.com/apache/ignite/pull/6434/files#diff-3da5dbb6f22e5bf3bf18734933f1bfc5R434
[2]
https://github.com/apache/ignite/pull/6434/files#diff-cd3a07ce10f21d396c1eac0c328850e0L179
was (Author: ivanan.fed):
[~Pavlukhin], I removed the garbage injection and left only one non-static cfg
variable.
Moreover, I assigned configuration directly before each test (and
beforeTestsStarted method) with reflection instead of injectTestsConfiguration
method invocation [1].
I think now it looks better and without unnecessary actions.
Also, I removed double stopAllGrids (I don't know why it's necessary to invoke
it twice - because of this Cache tests were broken) [2].
I checked RunAllNightly and new failures seem for me from the first view not
because of test workflow, but because of real reasons.
Could you take a look at such solution, please?
[1]https://github.com/apache/ignite/pull/6434/files#diff-3da5dbb6f22e5bf3bf18734933f1bfc5R434
[2]
https://github.com/apache/ignite/pull/6434/files#diff-cd3a07ce10f21d396c1eac0c328850e0L179
> Unable to run tests in IgniteConfigVariationsAbstractTest subclasses
> --------------------------------------------------------------------
>
> Key: IGNITE-11708
> URL: https://issues.apache.org/jira/browse/IGNITE-11708
> Project: Ignite
> Issue Type: Bug
> Reporter: Ivan Fedotov
> Assignee: Ivan Fedotov
> Priority: Major
> Labels: iep30
> Attachments: read_through_eviction_self_test.patch,
> tx_out_test_fixed.patch
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> It seems that test classes that extend from
> IgniteConfigVariationsAbstractTest cannot be started with JUnit4 @Test
> annotation.
> It is easy to check: if throw exception in any test methods, nothing will
> happen.
> Reason can be in rule chain in IgniteConfigVariationsAbstractTest class [1],
> maybe it destroys existing test workflow.
> [1]
> https://github.com/apache/ignite/blob/master/modules/core/src/test/java/org/apache/ignite/testframework/junits/IgniteConfigVariationsAbstractTest.java#L62
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
