[
https://issues.apache.org/jira/browse/IGNITE-10973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16891243#comment-16891243
]
Ivan Fedotov edited comment on IGNITE-10973 at 7/23/19 5:44 PM:
----------------------------------------------------------------
[~Pavlukhin] ,
According to Parametrized test - I added a new dependency in the last commit.
We can use @CsvSource or @ParameterizedTest/@ValueSource annotations: usage is
simplier than in the fourth version. Rule and ClassRule annotations can be
replaced by Extension and ExtendWith respectively.
According to .net tests: the reason for failures is the only one: "The filename
or extension is too long" in ExecutableTest [1]. I guess that it's jvmClasspath
because other args are hardcoded. I compared the log files from my branch[2]
and master[3]. For some reason, jvmClasspath
contains all maven dependencies. Because of addition more dependencies to pom
file, this string becomes too long for system .net function. I guess that it is
not correct behavior of Classpath.cs#CreateClasspath function, because if we
need to add some more dependencies to pom file, we faced this problem.
Moreover, it is not jvmClasspath, it's the enumeration of all jat files.
[1]
[https://github.com/apache/ignite/blob/master/modules/platforms/dotnet/Apache.Ignite.Core.Tests/ExecutableTest.cs#L148]
[2]
[https://ci.ignite.apache.org/viewLog.html?buildId=4318302&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_PlatformNetLongRunning]
[3]
[https://ci.ignite.apache.org/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=4381131&_focus=53179]
was (Author: ivanan.fed):
[~Pavlukhin] ,
According to Parametrized test - I added a new dependency in the last commit.
We can use @CsvSource or @ParameterizedTest/@ValueSource annotations: usage is
simplier than in the fourth version. Rule and ClassRule annotations can be
replaced by Extension and ExtendWith respectively.
According to .net tests: the reason for failures is the only one: "The filename
or extension is too long" in ExecutableTest [1]. I guess that it's jvmClasspath
because other args are hardcoded. I compared the log files from my branch[2]
and master[3]. For some reason, jvmClasspath
contains all maven dependencies. Because of addition more dependencies to pom
file, this string becomes too long for system .net function. I guess that it is
not correct behavior of Classpath.cs#CreateClasspath function, because if we
need to add some more dependencies to pom file, we faced this problem.
Moreover, it is not jvmClasspath, it's the enumeration of all jat files.
[1]
https://github.com/apache/ignite/blob/master/modules/platforms/dotnet/Apache.Ignite.Core.Tests/ExecutableTest.cs#L148
[2]
https://ci.ignite.apache.org/viewLog.html?buildId=4318302&tab=buildResultsDiv&buildTypeId=IgniteTests24Java8_PlatformNetLongRunning
[3]
https://ci.ignite.apache.org/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=4381131&_focus=53179
> Migrate example module tests from Junit 4 to 5
> ----------------------------------------------
>
> Key: IGNITE-10973
> URL: https://issues.apache.org/jira/browse/IGNITE-10973
> Project: Ignite
> Issue Type: Sub-task
> Reporter: Ivan Fedotov
> Assignee: Ivan Fedotov
> Priority: Major
> Labels: iep-30
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> For more information refer parent task.
> Migrate from Junit 4 to 5 in the example module.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
