[ 
https://issues.apache.org/jira/browse/IGNITE-12042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16901302#comment-16901302
 ] 

Vyacheslav Koptilin edited comment on IGNITE-12042 at 8/6/19 5:23 PM:
----------------------------------------------------------------------

Thank you, Pavel, for the review!

So, I would propose to change the formula as follows:
{code:java}
boolean oomThreshold = (memorySize / pageMem.systemPageSize()) <
(datarow.size() / pageMem.systemPageSize() + nonEmptyPages * (8.0 * 1.5 / 
pageMem.pageSize() + 1) + 256 /one page per bucket/);{code}
where:
 {{memorySize / pageMem.systemPageSize()) - total pages}}
 {{datarow.size() / pageMem.systemPageSize() - data row pages}}
 {{nonEmptyPages * (8.0 * 1.5 / pageMem.pageSize() + 1) - nonEmptyPages + 
linkPages (multiplied by 1.5)}}
 {{256 - additional pages reserved for buckets of FreeList}}

{{What do you think, [~xtern] [~ivan.glukos]? I am ready to update the PR and 
re-run TC. :)}}


was (Author: slava.koptilin):
Thank you, Pavel, for the review!

So, I propose to change the formula as follows:
{code:java}
boolean oomThreshold = (memorySize / pageMem.systemPageSize()) <
(datarow.size() / pageMem.systemPageSize() + nonEmptyPages * (8.0 * 1.5 / 
pageMem.pageSize() + 1) + 256 /one page per bucket/);{code}
where:
 {{memorySize / pageMem.systemPageSize()) - total pages}}
 {{datarow.size() / pageMem.systemPageSize() - data row pages}}
 {{nonEmptyPages * (8.0 * 1.5 / pageMem.pageSize() + 1) - nonEmptyPages + 
linkPages (multiplied by 1.5)}}
 {{256 - additional pages reserved for buckets of FreeList}}

{{What do you think, [~xtern] [~ivan.glukos]? I am ready to update the PR and 
re-run TC. :)}}

> Atempt to remove entries from fully populated data region may result in 
> IgineOutOfMemoryException
> -------------------------------------------------------------------------------------------------
>
>                 Key: IGNITE-12042
>                 URL: https://issues.apache.org/jira/browse/IGNITE-12042
>             Project: Ignite
>          Issue Type: Bug
>    Affects Versions: 2.7
>            Reporter: Vyacheslav Koptilin
>            Assignee: Vyacheslav Koptilin
>            Priority: Major
>             Fix For: 2.8
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Removing entries from non-persistent data region may require allocating a new 
> data page in order to move a tracked page from one bucket of the free-list to 
> another one.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to