[ https://issues.apache.org/jira/browse/IGNITE-12581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17025898#comment-17025898 ]
Vladimir Steshin commented on IGNITE-12581: ------------------------------------------- Suggested test to revise for parametrize possibility are: # CacheContinuousQueryCounterAbstractTest # GridCacheAbstractLocalStoreSelfTest # IgniteCacheNodeJoinAbstractTest # GridAbstractCacheInterceptorRebalanceTest # GridCacheOnCopyFlagAbstractSelfTest # IgniteCacheCopyOnReadDisabledAbstractTest # GridCacheInterceptorAbstractSelfTest # CacheGetsDistributionAbstractTest # CacheStoreSessionListenerReadWriteThroughDisabledAbstractTest # IgniteTxStoreExceptionAbstractSelfTest # GridCacheSetAbstractSelfTest # IgniteCacheAbstractExecutionContextTest # GridCacheAbstractUsersAffinityMapperSelfTest # IgniteCacheExpiryPolicyWithStoreAbstractTest # CacheVersionedEntryAbstractTest # GridCacheEvictionEventAbstractTest # GridCacheAbstractIteratorsSelfTest # CacheStoreUsageMultinodeDynamicStartAbstractTest # GridCacheAbstractFailoverTxSelfTest # CacheStoreUsageMultinodeStaticStartAbstractTest # IgniteCachePeekModesAbstractTest > [REFACTORING] Tests parametrization > ----------------------------------- > > Key: IGNITE-12581 > URL: https://issues.apache.org/jira/browse/IGNITE-12581 > Project: Ignite > Issue Type: Improvement > Reporter: Nikolay Izhikov > Assignee: Vladimir Steshin > Priority: Minor > > Right now many Ignite tests parametrization implemented via inheritance. > For example: > parent - JdbcThinBulkLoadAbstractSelfTest > extensions - JdbcThinBulkLoadAtomicPartitionedNearSelfTest, > JdbcThinBulkLoadAtomicPartitionedSelfTest, > JdbcThinBulkLoadAtomicReplicatedSelfTest, > JdbcThinBulkLoadTransactionalPartitionedNearSelfTest, > JdbcThinBulkLoadTransactionalPartitionedSelfTest, > JdbcThinBulkLoadTransactionalReplicatedSelfTest. > > Look like we can significantly reduce tests code base, therefore, improve > readability and maintainability without losing any test-cases if we use the > JUnit parameterized approach. > > A contributor can use this ticket as an umbrella one and create a sub-ticket > for each refactored test-classes. -- This message was sent by Atlassian Jira (v8.3.4#803005)