[
https://issues.apache.org/jira/browse/IGNITE-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14570833#comment-14570833
]
Artem Shutak commented on IGNITE-917:
-------------------------------------
Atri, if you open any link from comment above
(http://204.14.53.152/viewLog.html?buildId=54411 for example) you can see error
message "patch was not applied successfully". It means that patch cannon be
applied by "git am".
How to make correct patch:
https://cwiki.apache.org/confluence/display/IGNITE/How+to+Contribute.
About review. I do not commiter, but I see your patch doesn't pass
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines. Please,
fix it before conceptual review will be done.
> Add org.apache.ignite.cluster.ClusterGroup.forHost(String host, String...
> hosts) overload
> -----------------------------------------------------------------------------------------
>
> Key: IGNITE-917
> URL: https://issues.apache.org/jira/browse/IGNITE-917
> Project: Ignite
> Issue Type: Task
> Components: newbie
> Reporter: Yakov Zhdanov
> Assignee: Yakov Zhdanov
> Attachments: forhostver1.patch
>
>
> Method should build a cluster group from all nodes running on the hosts
> specified.
> This should be dynamic group. I think method implementation should build up a
> predicate to check that passed in node's host names contain one of the host
> names from parameters.
> See IgnitePredicate, ClusterGroup, ClusterNode, ClusterNode#hostNames
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
