[
https://issues.apache.org/jira/browse/IGNITE-917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14580321#comment-14580321
]
Atri Sharma commented on IGNITE-917:
------------------------------------
Hi,
Thanks for your review.
1) Fixed some extra spaces and renamed test.
For @param host, I thought that since variable name 'host' is lower case, doc
should also maintain same semantics. Please correct me if I am mistaken.
2) I meant to maintain a plain ArrayList of hostnames which could potentially
be used for other purposes later. I see your point and have removed the
ArrayList.
3) I have added another case in the test.
Please see and let me know your comments.
> Add org.apache.ignite.cluster.ClusterGroup.forHost(String host, String...
> hosts) overload
> -----------------------------------------------------------------------------------------
>
> Key: IGNITE-917
> URL: https://issues.apache.org/jira/browse/IGNITE-917
> Project: Ignite
> Issue Type: Task
> Components: newbie
> Reporter: Yakov Zhdanov
> Assignee: Yakov Zhdanov
> Attachments: ignite-sprint-5_ignite-917ver10.patch
>
>
> Method should build a cluster group from all nodes running on the hosts
> specified.
> This should be dynamic group. I think method implementation should build up a
> predicate to check that passed in node's host names contain one of the host
> names from parameters.
> See IgnitePredicate, ClusterGroup, ClusterNode, ClusterNode#hostNames
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
