[
https://issues.apache.org/jira/browse/IGNITE-788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588416#comment-14588416
]
Artem Shutak commented on IGNITE-788:
-------------------------------------
Hi, Gianfranco!
I looked at your patch and I have next notes:
- .settings, .classpath, .project directory/files have to be deleted. You can
add it to .gitignire.
- all source files have to have apache licence header. TeamCity has test on it
(see http://204.14.53.152/viewLog.html?buildId=55174 for example).
- Log4jFileAware name already used for log4j. It would be better to have
different names here. Use Log4j2FileAware. (see another classes too).
- SampleClass :)
- Code style. Ok, you have pretty good code style. I suggest you recheck all
places on extra empty lines and missed empty lines. Also, parameter description
at javadoc should start on the same line as paramether.
- Ok, and of course, all javadocs have to be in english :)
- we are using JUnit 3 (not older versions).
Thanks,
Artem.
> add support for log4j2 into org.apache.ignite.logger.log4j package
> (Log4J2Logger)
> ---------------------------------------------------------------------------------
>
> Key: IGNITE-788
> URL: https://issues.apache.org/jira/browse/IGNITE-788
> Project: Ignite
> Issue Type: New Feature
> Components: general, newbie
> Affects Versions: sprint-3
> Reporter: Yakov Zhdanov
> Assignee: Gianfranco Murador
> Labels: newbie
> Fix For: sprint-6
>
> Attachments: ignite-sprint-5_ignite-788.patch, patch-ingnite-788.zip
>
>
> This should be a new module. See {{ignite-log4j}} module for reference
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
