[
https://issues.apache.org/jira/browse/IGNITE-428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14588075#comment-14588075
]
Andrey Gura edited comment on IGNITE-428 at 6/17/15 12:17 PM:
--------------------------------------------------------------
Vishal, {{KafkaIgniteStreamerSelfTest}} is broken. Could you please fix it and
other review comments (see below)?
Code still doesn't satisfy our code style:
* Methods and constructors have poor javadoc or does not have it at all (see
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-JavadocComments).
* Code contains redundant brackets (see
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-BracketsandIdentation).
* Code lines in many cases should be separated by empty line
(https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-SemanticUnits)
* {{@Override}} annotation should be on the same line with code (see
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-@Annotations)
Also there are the following problems:
* Unchecked assignments (because of constructors invoking without diamond
operator).
* {{KafkaEmbeddedBroker.brokerReady}} field is assigned but never accessed
and can be removed.
* {{KafkaEmbeddedBroker.getZKAddress()}} static method has redundant
{{final}} modifier.
* {{KafkaEmbeddedBroker}} class contains expressions like {{zkReady ==
true}}. In this case equality operator should be removed.
* Apache Commons IO dependency is redundant. {{FileUtils.deleteDirectory}}
method can be replaced by {{U.delete}}.
* {{KafkaStreamer}} class contains unnecessary integer boxing on line 130.
* In {{KafkaStreamer}} class {{while}} cycle could be replaced by foreach on
line 146.
* In {{KafkaStreamer}} class at line 164 {{executor.awaitTermination}} can
produce NPE.
was (Author: agura):
Vishal, {{KafkaIgniteStreamerSelfTest}} is broken. Could you please fix it and
other review comments (see below)?
Code still doesn't satisfy our code style:
* Methods and constructors have poor javadoc or does not have it at all (see
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-JavadocComments).
* Code contains redundant brackets (see
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-BracketsandIdentation).
* Code lines in many cases should be separated by empty line
(https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-SemanticUnits)
* {{@Override}} annotation should be on the same line with code (see
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines#CodingGuidelines-@Annotations)
Also there are the following problems:
* Unchecked assignments (because of constructors invoking without diamond
operator).
* {{KafkaEmbeddedBroker.brokerReady}} field is assigned but never accessed
and can be removed.
* {{KafkaEmbeddedBroker.getZKAddress()}} static method has redundant
{{final}} modifier.
* {{KafkaEmbeddedBroker}} class contains expressions like {{zkReady ==
true}}. In this case equality operator should be removed.
* Apache Commons IO dependency is redundant. {{FileUtils.deleteDirectory}}
method can be replaced by {{U.delete}}.
* {{KafkaStreamer}} class contains unnecessary integer boxing on line 130.
* In {{Kaf kaStreamer}} class {{while}} cycle could be replaced by foreach on
line 146.
* In {{Kaf kaStreamer}} class at line 164 {{executor.awaitTermination}} can
produce NPE.
> Implement IgniteKafkaStreamer to stream data from Apache Kafka
> --------------------------------------------------------------
>
> Key: IGNITE-428
> URL: https://issues.apache.org/jira/browse/IGNITE-428
> Project: Ignite
> Issue Type: Sub-task
> Components: streaming
> Affects Versions: sprint-5
> Reporter: Dmitriy Setrakyan
> Assignee: Vishal Garg
> Attachments: ignite-sprint-5_ignite-428.patch,
> ignite-sprint-5_ignite-428.patch
>
>
> We have {{IgniteDataStreamer}} which is used to load data into Ignite under
> high load. It was previously named {{IgniteDataLoader}}, see ticket
> IGNITE-394.
> See [Apache Kafka|http://kafka.apache.org/] for more information.
> We should create {{IgniteKafkaStreamer}} which will consume messages from
> Kafka and stream them into Ignite caches.
> More details to follow, but to the least we should be able to:
> - Convert Kafka messages to Ignite data using an optional pluggable converter.
> - Specify the cache name for the Ignite cache to load data into.
> - Specify other flags available on {{IgniteDataStreamer}} class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
