[
https://issues.apache.org/jira/browse/IGNITE-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694518#comment-14694518
]
Valentin Kulichenko commented on IGNITE-534:
--------------------------------------------
Raul,
Please also take a look at this pages:
https://cwiki.apache.org/confluence/display/IGNITE/Coding+Guidelines
https://cwiki.apache.org/confluence/display/IGNITE/Abbreviation+Rules
My comments:
* Bracing for one-liner ifs or loops is not required and usually is not used.
E.g., this code:
{code}
if (clientId != null && clientId.trim().length() > 0) {
connection.setClientID(clientId.trim());
}
{code}
should be:
{code}
if (clientId != null && clientId.trim().length() > 0)
connection.setClientID(clientId.trim());
{code}
* Semantic units have to be separated by empty lines. E.g., this code:
{code}
stopped = true;
if (scheduler != null && !scheduler.isShutdown()) {
scheduler.shutdown();
scheduler = null;
}
connection.stop();
connection.close();
{code}
should look like this:
{code}
stopped = true;
if (scheduler != null && !scheduler.isShutdown()) {
scheduler.shutdown();
scheduler = null;
}
connection.stop();
connection.close();
{code}
> Implement IgniteJmsStreamer to stream data from a JMS broker like ActiveMQ
> --------------------------------------------------------------------------
>
> Key: IGNITE-534
> URL: https://issues.apache.org/jira/browse/IGNITE-534
> Project: Ignite
> Issue Type: Sub-task
> Components: streaming
> Reporter: Dmitriy Setrakyan
> Assignee: Valentin Kulichenko
>
> We have {{IgniteDataStreamer}} which is used to load data into Ignite under
> high load. It was previously named {{IgniteDataLoader}}, see ticket
> IGNITE-394.
> We should create {{IgniteJmsStreamer}} which will consume messages from a
> given queue or topic of a JMS broker and stream them into Ignite caches.
> Even though we'll use AMQ for testing, this streamer should be
> implementation-agnostic and only use JMS constructs where possible.
> See [Apache ActiveMQ|http://activemq.apache.org/] for more information.
> More details to follow, but to the least we should be able to:
> * Convert a JMS message to Ignite data using an optional pluggable converter.
> If not provided, we should have some default mechanism.
> * Specify the cache name for the Ignite cache to load data into.
> * Specify other flags available on {{IgniteDataStreamer}} class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
