[ 
https://issues.apache.org/jira/browse/IGNITE-534?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695035#comment-14695035
 ] 

Raúl Kripalani edited comment on IGNITE-534 at 8/13/15 10:33 AM:
-----------------------------------------------------------------

bq. Bracing for one-liner ifs or loops is not required and usually is not used. 
E.g., this code:

The documentation said:

bq. Brackets are required in all cases, even if not required by syntax, except 
for the cases when next statement is one-liner. The following code does not 
require brackets.

"Does not require brackets" does not denote norm: it denotes preference.

The entire section was unclear. I replaced the term "Brackets" for "Braces" and 
made the "no braces on one-line blocks" a norm.

bq. Semantic units have to be separated by empty lines. E.g., this code:

I agree with the separations you suggest except for the scheduler. Could you 
explain why you want it this way? For me it's the same "semantical unit".


was (Author: raulvk):
bq. Bracing for one-liner ifs or loops is not required and usually is not used. 
E.g., this code:

The documentation says:

bq. Brackets are required in all cases, even if not required by syntax, except 
for the cases when next statement is one-liner. The following code does not 
require brackets.

"Does not require brackets" does not denote norm: it denotes preference.

The entire section was unclear. I replaced the term "Brackets" for "Braces" and 
made the "no braces on one-line blocks" a norm.

bq. Semantic units have to be separated by empty lines. E.g., this code:

I agree with the separations you suggest except for the scheduler. Could you 
explain why you want it this way? For me it's the same "semantical unit".

> Implement IgniteJmsStreamer to stream data from a JMS broker like ActiveMQ
> --------------------------------------------------------------------------
>
>                 Key: IGNITE-534
>                 URL: https://issues.apache.org/jira/browse/IGNITE-534
>             Project: Ignite
>          Issue Type: Sub-task
>          Components: streaming
>            Reporter: Dmitriy Setrakyan
>            Assignee: Valentin Kulichenko
>
> We have {{IgniteDataStreamer}} which is used to load data into Ignite under 
> high load. It was previously named {{IgniteDataLoader}}, see ticket 
> IGNITE-394.
> We should create {{IgniteJmsStreamer}} which will consume messages from a 
> given queue or topic of a JMS broker and stream them into Ignite caches.
> Even though we'll use AMQ for testing, this streamer should be 
> implementation-agnostic and only use JMS constructs where possible.
> See [Apache ActiveMQ|http://activemq.apache.org/] for more information.
> More details to follow, but to the least we should be able to:
> * Convert a JMS message to Ignite data using an optional pluggable converter. 
> If not provided, we should have some default mechanism.
> * Specify the cache name for the Ignite cache to load data into.
> * Specify other flags available on {{IgniteDataStreamer}} class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to