Jinchul Kim created IMPALA-6336: ----------------------------------- Summary: Follow code convention for function method in fe Key: IMPALA-6336 URL: https://issues.apache.org/jira/browse/IMPALA-6336 Project: IMPALA Issue Type: Improvement Components: Infrastructure Affects Versions: Impala 2.10.0 Reporter: Jinchul Kim
Regarding coding convention, especially function name, in Java, I am confusing which function name is right: lowerCamelCase or UpperCamelCase. I guess we may follow lowerCamelCase: https://google.github.io/styleguide/javaguide.html#s5.2.3-method-names By the way, some codes did not follow the convention. Please see fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java#L113,126. I could see similar case in some files. Do we have to align function name? What do you think about this? - From Tim's comment: Yes, Java should use lowerCamelCase. C++ uses UpperCamelCase. This does seem inconsistent but is inherited from the Google styles. I agree that some functions in Java are not following the convention, e.g. AnalyzesOk(). I don't know why they are different. It would be nice to fix them to be consistent but I'd be concerned about the merge conflicts resulting. -- This message was sent by Atlassian JIRA (v6.4.14#64029)