[ 
https://issues.apache.org/jira/browse/IMPALA-7157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sailesh Mukil resolved IMPALA-7157.
-----------------------------------
       Resolution: Fixed
    Fix Version/s: Impala 3.1.0

> Avoid unnecessarily pretty printing profiles per fragment instance
> ------------------------------------------------------------------
>
>                 Key: IMPALA-7157
>                 URL: https://issues.apache.org/jira/browse/IMPALA-7157
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Distributed Exec
>            Reporter: Sailesh Mukil
>            Assignee: Sailesh Mukil
>            Priority: Minor
>              Labels: logs
>             Fix For: Impala 3.1.0
>
>
> In SendReport(), if VLOG_FILE_IS_ON is 'true' (which is not the most verbose 
> logging level, but is higher than default), we pretty print the profile for 
> every fragment instance, which is a very expensive operation, as serializing 
> the profile is non-trivial (look at RuntimeProfile::PrettyPrint()), and 
> printing large amounts of information to the logs isn't cheap as well. 
> Lastly, it is very noisy.
> This seems unnecessary since this will not benefit us, as all the profiles 
> are merged at the coordinator side. We could argue that this might be 
> necessary when an executor fails to send the profile to the coordinator, but 
> that signifies a network issue which will not be reflected in the profile of 
> any fragment instance.
> This will help reduce noise in the logs when the log level is bumped up to 
> find other real issues that VLOG_FILE can help with.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to