Tim Armstrong created IMPALA-9623:
-------------------------------------

             Summary: Replace architecture-specific atomics with C++11 atomics
                 Key: IMPALA-9623
                 URL: https://issues.apache.org/jira/browse/IMPALA-9623
             Project: IMPALA
          Issue Type: Improvement
          Components: Backend
            Reporter: Tim Armstrong
         Attachments: 0001-WIP-on-generic-atomics.-Not-compiling-yet.patch

The atomic operations in gutil/ use inline assembly for each architecture. 
Chromium, which is the upstream for gutil, has switched to generic atomic 
operations instead: 
[https://github.com/chromium/chromium/blob/2ca8c5037021c9d2ecc00b787d58a31ed8fc8bcb/base/atomicops.h#L152]

 

It would be nice to make the corresponding change and make our codebase more 
portable. I did a dry run of this and ran into some minor issues with 
compiling, but it looked feasible. I'll attach here: 
[^0001-WIP-on-generic-atomics.-Not-compiling-yet.patch]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to