[ https://issues.apache.org/jira/browse/IMPALA-6004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Thomas Tauber-Marshall resolved IMPALA-6004. -------------------------------------------- Resolution: Fixed commit e7b1c321033c1201ee88c9695c44535bd02a2f4e Author: Thomas Tauber-Marshall <tmarsh...@cloudera.com> Date: Mon Oct 23 11:33:41 2017 -0700 IMPALA-6004: Fix test_row_filters failure on ASAN 'Test case 16' in test_row_filters has been failing occasionaly on ASAN as the runtime filters are not generated within the specified RUNTIME_FILTER_WAIT_TIME_MS. The fix is to increase RUNTIME_FILTER_WAIT_TIME_MS. This patch updates all of the tests in test_row_filters to use the same timeout, which is set to a higher value for ASAN builds. Change-Id: Ia098735594b36a72f02bf7edd051171689618051 Reviewed-on: http://gerrit.cloudera.org:8080/8358 Reviewed-by: Alex Behm <alex.b...@cloudera.com> Tested-by: Impala Public Jenkins > Failures in TestRuntimeFilters.test_wait_time and > TestRuntimeRowFilters.test_row_filters on ASAN > ------------------------------------------------------------------------------------------------ > > Key: IMPALA-6004 > URL: https://issues.apache.org/jira/browse/IMPALA-6004 > Project: IMPALA > Issue Type: Bug > Components: Infrastructure > Affects Versions: Impala 2.10.0, Impala 2.11.0 > Reporter: Alexander Behm > Assignee: Thomas Tauber-Marshall > Priority: Blocker > Labels: flaky > > Seeing the following failures in TestRuntimeFilters: > This commit might be the culprit: > c1781b73b35899ed9374befa2e04e14747224be7 > TestRuntimeFilters.test_wait_time > {code} > 08:02:04.164 =================================== FAILURES > =================================== > 08:02:04.164 TestRuntimeFilters.test_wait_time[exec_option: {'batch_size': > 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 0, 'disable_codegen': > False, 'abort_on_error': 1, 'exec_single_node_rows_threshold': 0} | > table_format: avro/snap/block] > 08:02:04.164 [gw3] linux2 -- Python 2.6.6 > /data/jenkins/workspace/impala-umbrella-build-and-test/repos/Impala/bin/../infra/python/env/bin/python > 08:02:04.164 query_test/test_runtime_filters.py:47: in test_wait_time > 08:02:04.164 assert duration < 60, \ > 08:02:04.164 E AssertionError: Query took too long (61.5202310085s, > possibly waiting for missing filters?) > 08:02:04.164 E assert 61.520231008529663 < 60 > 08:02:04.164 ----------------------------- Captured stderr call > ----------------------------- > 08:02:04.164 -- executing against localhost:21000 > 08:02:04.164 use functional_avro_snap; > 08:02:04.164 > 08:02:04.164 SET batch_size=0; > 08:02:04.164 SET num_nodes=0; > 08:02:04.164 SET disable_codegen_rows_threshold=0; > 08:02:04.164 SET disable_codegen=False; > 08:02:04.164 SET abort_on_error=1; > 08:02:04.164 SET exec_single_node_rows_threshold=0; > 08:02:04.164 -- executing against localhost:21000 > 08:02:04.164 > 08:02:04.164 set RUNTIME_FILTER_WAIT_TIME_MS=600000; > 08:02:04.164 > 08:02:04.164 -- executing against localhost:21000 > 08:02:04.164 > 08:02:04.164 set RUNTIME_FILTER_MODE=LOCAL; > 08:02:04.164 > 08:02:04.164 -- executing against localhost:21000 > 08:02:04.164 > 08:02:04.164 select count(*) from alltypes p join [SHUFFLE] alltypestiny b > 08:02:04.164 on p.month = b.int_col and b.month = 1 and b.string_col = "1"; > 08:02:04.164 > 08:02:04.164 -- executing against localhost:21000 > 08:02:04.164 SET RUNTIME_FILTER_WAIT_TIME_MS="0"; > 08:02:04.164 > 08:02:04.164 -- executing against localhost:21000 > 08:02:04.164 SET RUNTIME_FILTER_MODE="2"; > 08:02:04.164 > 08:02:04.164 -- executing against localhost:21000 > 08:02:04.164 > 08:02:04.164 SET RUNTIME_FILTER_WAIT_TIME_MS=600000; > 08:02:04.164 > 08:02:04.164 -- executing against localhost:21000 > 08:02:04.164 > 08:02:04.164 SET RUNTIME_FILTER_MODE=GLOBAL; > 08:02:04.164 > 08:02:04.164 -- executing against localhost:21000 > 08:02:04.164 > 08:02:04.164 SET RUNTIME_FILTER_MAX_SIZE=4096; > 08:02:04.164 > 08:02:04.164 -- executing against localhost:21000 > 08:02:04.164 > 08:02:04.164 select STRAIGHT_JOIN count(*) from alltypes a > 08:02:04.164 join [BROADCAST] > 08:02:04.164 (select id, int_col from alltypes UNION ALL select id, > int_col from alltypes) b > 08:02:04.164 on a.id = b.id > 08:02:04.164 where (b.id - b.id) < 1 AND (b.int_col - b.int_col) < 1; > 08:02:04.164 > 08:02:04.164 -- executing against localhost:21000 > 08:02:04.164 SET RUNTIME_FILTER_WAIT_TIME_MS="0"; > 08:02:04.164 > 08:02:04.164 -- executing against localhost:21000 > 08:02:04.164 SET RUNTIME_FILTER_MODE="2"; > 08:02:04.164 > 08:02:04.164 -- executing against localhost:21000 > 08:02:04.164 SET RUNTIME_FILTER_MAX_SIZE="16777216"; > 08:02:04.164 > 08:02:04.164 ====== 1 failed, 1493 passed, 47 skipped, 36 xfailed in 14009.54 > seconds ======= > 08:02:04.164 ============================= test session starts > ============================== > {code} > TestRuntimeRowFilters.test_row_filters > {code} > 08:12:05.811 =================================== FAILURES > =================================== > 08:12:05.811 TestRuntimeRowFilters.test_row_filters[exec_option: > {'batch_size': 0, 'num_nodes': 0, 'disable_codegen_rows_threshold': 0, > 'disable_codegen': False, 'abort_on_error': 1, > 'exec_single_node_rows_threshold': 0} | table_format: parquet/none] > 08:12:05.811 [gw2] linux2 -- Python 2.6.6 > /data/jenkins/workspace/impala-umbrella-build-and-test/repos/Impala/bin/../infra/python/env/bin/python > 08:12:05.811 query_test/test_runtime_filters.py:64: in test_row_filters > 08:12:05.811 self.run_test_case('QueryTest/runtime_row_filters', vector) > 08:12:05.811 common/impala_test_suite.py:431: in run_test_case > 08:12:05.811 verify_runtime_profile(test_section['RUNTIME_PROFILE'], > result.runtime_profile) > 08:12:05.811 common/test_result_verifier.py:560: in verify_runtime_profile > 08:12:05.811 actual)) > 08:12:05.811 E AssertionError: Did not find matches for lines in runtime > profile: > 08:12:05.811 E EXPECTED LINES: > 08:12:05.811 E row_regex: .*Rows processed: 16.38K.* > ... > 08:12:05.815 -- executing against localhost:21000 > 08:12:05.815 SET BUFFER_POOL_LIMIT="0"; > 08:12:05.815 > 08:12:05.815 -- executing against localhost:21000 > 08:12:05.815 SET RUNTIME_FILTER_MODE="2"; > 08:12:05.815 > 08:12:05.815 -- executing against localhost:21000 > 08:12:05.815 SET RUNTIME_FILTER_WAIT_TIME_MS="0"; > 08:12:05.815 > 08:12:05.815 -- executing against localhost:21000 > 08:12:05.815 SET RUNTIME_BLOOM_FILTER_SIZE="1048576"; > 08:12:05.815 > 08:12:05.815 ====== 1 failed, 1493 passed, 47 skipped, 36 xfailed in 14833.47 > seconds ======= > 08:12:05.815 ============================= test session starts > ============================== > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029)