Aklakan commented on issue #3044: URL: https://github.com/apache/jena/issues/3044#issuecomment-2702118002
The problem with eager iterators in the snippet below is, that if `getPlan().iterator()` fails, then there is no resource that can be closed -> likely resource leak. https://github.com/apache/jena/blob/6a86b5d1869c575142391e3e8bcc8f00f1a75132/jena-arq/src/main/java/org/apache/jena/sparql/exec/QueryExecDataset.java#L472-L475 IMO the clean solution would be to change AbstractIterHashJoin to be lazy, then the lock would only be held shortly for the iterator construction, and then the timeout can kick in normally. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
