afs commented on issue #4084: URL: https://github.com/apache/jena/issues/4084#issuecomment-5055567310
There's no dispute about what Jetty is doing. The question is what to do about it. How the Fuseki should be configuring Jetty for a better setup. A Jetty server is also created via this route: https://github.com/apache/jena/blob/main/jena-fuseki2/jena-fuseki-main/src/main/java/org/apache/jena/fuseki/main/FusekiServer.java#L1907 Maybe Jena's JettyServer needs one place to create the server and that has a function argument to modify the connection before atatchign it to the Jetty server function so JettyHttps can set up the HTTPS connection layer. Or (old skool) have a separate "create base connection" function in Fuseki's JettyServer and server creation is two steps (2 calls to JettyServer , one for network connector, one for the server). A PR would be great. Sounds like a few, important lines, not a redesign. (Just don't let the AI rewrite code unnecessarily!) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
