[ https://issues.apache.org/jira/browse/KARAF-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12898823#action_12898823 ]
Guillaume Nodet commented on KARAF-40: -------------------------------------- Just a few remarks: * i'm not very keen on the karaf-command-archetype and karaf-archetypes-itests names for the maven modules, shouldn''t they be command and itests, given they are in the archetypes folder already ? that would be more consistent with the remaining of the project * maybe the code for the function generated should print something to std out like "Executing command xxx" so that the user can visually see something with a bare generated artifact * I don't think the generated maven project should inherit from a karaf project Those are not critical problems and i'm really open to discuss those if you have a different point of view. > Create a maven archetype for creating shell commands > ---------------------------------------------------- > > Key: KARAF-40 > URL: https://issues.apache.org/jira/browse/KARAF-40 > Project: Karaf > Issue Type: Task > Reporter: Guillaume Nodet > Attachments: command-archetype-patch.txt, karaf-archetypes-patch.txt > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.