[ 
https://issues.apache.org/jira/browse/KARAF-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156862#comment-13156862
 ] 

Ioannis Canellos commented on KARAF-1029:
-----------------------------------------

Guillaume proposed this great idea on irc:

<gnodet> iocanel: about options completers, wouldn't it make more sense to have 
a map and identify them by the option name rather than the completer class name 
?
<gnodet> iocanel: it seems to me that you could very well have multiple options 
with the same completers class
<gnodet> (even if configured with different values)
<iocanel> gnodet, makes sense to me
<gnodet> so i'd remove the completer from @Option and use something like 
<optional-completers><key value="-furl" ref="allFeatureCompleter">...</
<gnodet> and then the code would try to find the correct completer
<iocanel> gnodet, yes it will be much better this way

The suggestion is committed to trunk.


                
> Add completer support on option values
> --------------------------------------
>
>                 Key: KARAF-1029
>                 URL: https://issues.apache.org/jira/browse/KARAF-1029
>             Project: Karaf
>          Issue Type: New Feature
>          Components: karaf-shell
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Ioannis Canellos
>             Fix For: 3.0.0
>
>
> Currently, Karaf console provides completion on the option name.
> As discussed with Ioannis, it could be interesting to add completer support 
> for option values.
> For instance, mycommand --config where the user can specify a configuration 
> PID in the config option, it could be helpful to have completion for the PID.
> The proposal is to use a new annotation for option, for instance:
> @Option
> @Completer(type = ConfigCompleter.class)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to