[ 
https://issues.apache.org/jira/browse/KARAF-1657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420484#comment-13420484
 ] 

Freeman Fang commented on KARAF-1657:
-------------------------------------

Hi Andreas,

We currently comment out org.ops4j.pax.url.mvn.proxySupport configuration by 
default, which means in Karaf we  use default value  of 
org.ops4j.pax.url.mvn.proxySupport from PAX-URL out-of-box so far, which is 
"true"(according to PAX-URL docs). By my test, the default 
org.ops4j.pax.url.mvn.proxySupport=true in  PAX-URL  means, it will just try to 
use(but not only use proxy) maven proxy support if the proxy configuration is 
in maven settings.xml and the proxy is available. That said,  PAX-URL  can 
still use normal maven way even the proxy isn't available or there's no proxy 
configuration in maven settings.xml with default 
org.ops4j.pax.url.mvn.proxySupport=true. 

So the current configuration (including the comments)
#
# Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
# from the Maven conf/settings.xml file
#
# org.ops4j.pax.url.mvn.proxySupport=true

isn't correct, as it's actually same behavior with or without
org.ops4j.pax.url.mvn.proxySupport=true

So I think we need change it to
#
# Uncomment if you don't wanna use the proxy settings
# from the Maven conf/settings.xml file
#
# org.ops4j.pax.url.mvn.proxySupport=false

And I don't see the side effect of this change, as all what we change is still 
in the comment.

I might miss something, so if other guys have different input, please let me 
know.

Regards
Freeman
                
> org.ops4j.pax.url.mvn.proxySupport=false
> ----------------------------------------
>
>                 Key: KARAF-1657
>                 URL: https://issues.apache.org/jira/browse/KARAF-1657
>             Project: Karaf
>          Issue Type: Improvement
>            Reporter: Michael Prieß
>            Assignee: Freeman Fang
>
> {code}
> #
> # Uncomment if you are behind a web proxy. PAX URL will use the proxy settings
> # from the Maven conf/settings.xml file
> #
> # org.ops4j.pax.url.mvn.proxySupport=true
> {code}
> http://team.ops4j.org/wiki/display/paxurl/Mvn+Protocol 
> The configuration of pax url is per default true. If you read this comment 
> inside org.ops4j.pax.url.mvn.cfg you expect that the default configuration 
> must be false. 
> I prefer to set the configuration per default to false.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to