[
https://issues.apache.org/jira/browse/KARAF-4255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15224148#comment-15224148
]
Jean-Baptiste Onofré commented on KARAF-4255:
---------------------------------------------
I confirm that reverting this change allows to start cleanly even without
Internet connection. Let me revert on master and karaf-4.0.x branch, and I will
postpone this issue to 4.0.6.
> karaf-maven-plugin does include unused feature conditional dependencies in
> assembly
> -----------------------------------------------------------------------------------
>
> Key: KARAF-4255
> URL: https://issues.apache.org/jira/browse/KARAF-4255
> Project: Karaf
> Issue Type: Bug
> Affects Versions: 4.0.3
> Reporter: Fabian Lange
> Assignee: Jean-Baptiste Onofré
> Fix For: 4.1.0, 4.0.5
>
>
> I am using karaf-maven-plugin to make a custom assembly.
> I do include SCR, but I do not include webconsole.
> When I look into the system folder of my generated assembly, I can see:
> {code}
> target/assembly/system/org/apache/felix/org.apache.felix.webconsole.plugins.ds/2.0.2/org.apache.felix.webconsole.plugins.ds-2.0.2.jar
> {code}
> this correlates to the maven output:
> {code}
> [INFO] Feature scr is defined as a boot feature
> [INFO] == Installing artifact
> mvn:org.apache.karaf.scr/org.apache.karaf.scr.command/4.0.3
> [INFO] == Installing artifact mvn:org.apache.felix/org.apache.felix.scr/2.0.2
> [INFO] == Installing artifact
> mvn:org.apache.felix/org.apache.felix.scr.compat/1.0.2
> [INFO] == Installing artifact
> mvn:org.apache.felix/org.apache.felix.webconsole.plugins.ds/2.0.2
> [INFO] == Installing artifact
> mvn:org.apache.felix/org.apache.felix.metatype/1.1.2
> [INFO] == Installing artifact
> mvn:org.apache.karaf.scr/org.apache.karaf.scr.management/4.0.3
> {code}
> however looking at:
> https://github.com/apache/karaf/blob/master/assemblies/features/standard/src/main/feature/feature.xml#L524
> you can see that this is an conditional dependency only.
> This is caused by the fact that assembly does not check if the conditional
> had been met:
> https://github.com/apache/karaf/blob/master/profile/src/main/java/org/apache/karaf/profile/assembly/Builder.java#L822
> I believe we need a check for the conditionals wether the condition is
> actually met.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
