[ 
https://issues.apache.org/jira/browse/KARAF-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16482585#comment-16482585
 ] 

Karen edited comment on KARAF-5693 at 5/21/18 3:03 PM:
-------------------------------------------------------

This commit possibly threw out the baby with the bathwater? 
[https://github.com/apache/karaf/commit/59c11e4deebd6940136149a44f8485a941653e28]

It does at lot more than revert KARAF-3956. It also reverted KARAF-3791

commit 61f2436fc15b71afdec896873bb764c60d69b94a
 Author: Jean-Baptiste Onofré <jbono...@apache.org>
 Date:   Fri Jun 19 13:33:32 2015 +0200

    KARAF-3791 Fix etc/config.properties, especially used by instances

 

The "revert" commit also created an inconsistency with the karaf demo 
config.properties.


was (Author: kdolan):
This commit possibly threw out the baby with the bathwater? 
[https://github.com/apache/karaf/commit/59c11e4deebd6940136149a44f8485a941653e28]

It does at lot more than revert KARAF-3956. It also reverted KARAF-3791

commit 61f2436fc15b71afdec896873bb764c60d69b94a
Author: Jean-Baptiste Onofré <jbono...@apache.org>
Date:   Fri Jun 19 13:33:32 2015 +0200

    [KARAF-3791] Fix etc/config.properties, especially used by instances

> Incomplete config.properties file in built assemblies
> -----------------------------------------------------
>
>                 Key: KARAF-5693
>                 URL: https://issues.apache.org/jira/browse/KARAF-5693
>             Project: Karaf
>          Issue Type: Bug
>    Affects Versions: 4.0.10
>            Reporter: Greg Logan
>            Priority: Major
>         Attachments: broken.log, broken.properties, working.log, 
> working.properties
>
>
> Over at the Opencast project (https://github.com/opencast/opencast) we rarely 
> (1/20 or so) have assemblies seem to build correctly, but a number of 
> libraries required for the assembly to boot with all installed modules will 
> be missing from config.properties.  A repackage of the same codebase and 
> built artifacts resolves the issue, so this seems to be related to the 
> assembly itself rather than the underlying modules.  This also seems to be 
> independent of our branches, and versions - we've been observing this 
> off-and-on for more than a year but I've just never gotten around to filing 
> this.
>  
> Things attached:
>  * working and broken.log: full build outputs (including component 
> compilation) of the working and failing builds, respectively
>  * working and broken.properties: the config.properties generated in the 
> working, and failing builds, respectively.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to