[
https://issues.apache.org/jira/browse/KARAF-7766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17768560#comment-17768560
]
ASF GitHub Bot commented on KARAF-7766:
---------------------------------------
wborn commented on code in PR #1782:
URL: https://github.com/apache/karaf/pull/1782#discussion_r1335479111
##########
assemblies/features/base/src/main/filtered-resources/resources/bin/karaf.bat:
##########
@@ -418,56 +418,39 @@ if "%KARAF_PROFILER%" == "" goto :RUN
if "%IS_RUNNABLE%" == "true" (
rem If major version is greater than 1 (meaning Java 9 or 10), we
don't use endorsed lib but module
rem If major version is 1 (meaning Java 1.6, 1.7, 1.8), we use
endorsed lib
Review Comment:
Thanks for working on this. :+1:
I think this comment can also be removed:
```suggestion
```
> Require Java 11 to launch Karaf
> -------------------------------
>
> Key: KARAF-7766
> URL: https://issues.apache.org/jira/browse/KARAF-7766
> Project: Karaf
> Issue Type: Task
> Components: karaf
> Reporter: Robert Varga
> Priority: Major
>
> Reject any runtime < Java 11 and optimize launch scripts based on that
> assumption.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)