[
https://issues.apache.org/jira/browse/KARAF-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17777842#comment-17777842
]
ASF GitHub Bot commented on KARAF-7754:
---------------------------------------
rovarga commented on code in PR #1785:
URL: https://github.com/apache/karaf/pull/1785#discussion_r1367154542
##########
examples/karaf-websocket-example/src/main/java/org/apache/karaf/examples/websocket/WebsocketExampleServlet.java:
##########
@@ -16,16 +16,16 @@
*/
package org.apache.karaf.examples.websocket;
-import org.eclipse.jetty.websocket.servlet.WebSocketServlet;
-import org.eclipse.jetty.websocket.servlet.WebSocketServletFactory;
+import org.eclipse.jetty.websocket.server.JettyWebSocketServlet;
+import org.eclipse.jetty.websocket.server.JettyWebSocketServletFactory;
import javax.servlet.annotation.WebServlet;
@WebServlet(name = "Example WebSocket Servlet", urlPatterns = {
"/example-websocket "})
-public class WebsocketExampleServlet extends WebSocketServlet {
+public class WebsocketExampleServlet extends JettyWebSocketServlet {
Review Comment:
> We should use the websocket handling here, not the Jetty one.
This is just the Jetty 9.4 -> 10 renaming. Do you mean to switch the
example to just use JSR356?
> Require Java 11 at build and runtime
> ------------------------------------
>
> Key: KARAF-7754
> URL: https://issues.apache.org/jira/browse/KARAF-7754
> Project: Karaf
> Issue Type: Epic
> Components: karaf
> Reporter: Robert Varga
> Assignee: Jean-Baptiste Onofré
> Priority: Major
>
> Java 11 has been around forever. Jumping to this release is going to make
> things easier, as we do not have to deal with the packaging differences
> between Java 8 and Java 9+, allowing us to address a number of outstanding
> issues.
> This is also a prerequisite for KARAF-7544.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
