[
https://issues.apache.org/jira/browse/KARAF-7950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17947266#comment-17947266
]
ASF GitHub Bot commented on KARAF-7950:
---------------------------------------
jbonofre commented on code in PR #1937:
URL: https://github.com/apache/karaf/pull/1937#discussion_r2059800794
##########
bundle/core/pom.xml:
##########
@@ -56,16 +56,22 @@
<artifactId>org.apache.aries.blueprint.api</artifactId>
<scope>provided</scope>
</dependency>
-
- <dependency>
+
+ <dependency>
<groupId>org.osgi</groupId>
- <artifactId>osgi.core</artifactId>
- <scope>provided</scope>
+ <artifactId>org.osgi.framework</artifactId>
Review Comment:
The scope should be `provided` here.
##########
bundle/springstate/pom.xml:
##########
@@ -59,8 +59,7 @@
<dependency>
<groupId>org.osgi</groupId>
- <artifactId>osgi.core</artifactId>
- <scope>provided</scope>
+ <artifactId>org.osgi.framework</artifactId>
Review Comment:
The scope should be `provided` here.
##########
bom/pom.xml:
##########
@@ -97,8 +190,8 @@
</dependency>
<dependency>
<groupId>org.osgi</groupId>
- <artifactId>org.osgi.namespace.service</artifactId>
Review Comment:
I guess we still need `namespace`.
##########
bundle/core/pom.xml:
##########
@@ -56,16 +56,22 @@
<artifactId>org.apache.aries.blueprint.api</artifactId>
<scope>provided</scope>
</dependency>
-
- <dependency>
+
+ <dependency>
<groupId>org.osgi</groupId>
- <artifactId>osgi.core</artifactId>
- <scope>provided</scope>
+ <artifactId>org.osgi.framework</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.osgi</groupId>
+ <artifactId>org.osgi.resource</artifactId>
Review Comment:
The scope should be `provided` here.
##########
config/command/pom.xml:
##########
@@ -53,18 +53,15 @@
<dependencies>
<dependency>
<groupId>org.osgi</groupId>
- <artifactId>osgi.core</artifactId>
- <scope>provided</scope>
+ <artifactId>org.osgi.framework</artifactId>
Review Comment:
The scope should be `provided` here.
##########
config/command/pom.xml:
##########
@@ -53,18 +53,15 @@
<dependencies>
<dependency>
<groupId>org.osgi</groupId>
- <artifactId>osgi.core</artifactId>
- <scope>provided</scope>
+ <artifactId>org.osgi.framework</artifactId>
</dependency>
<dependency>
<groupId>org.osgi</groupId>
<artifactId>org.osgi.service.cm</artifactId>
Review Comment:
The scope should be `provided` here.
> Use modular OSGi dependencies
> -----------------------------
>
> Key: KARAF-7950
> URL: https://issues.apache.org/jira/browse/KARAF-7950
> Project: Karaf
> Issue Type: Improvement
> Reporter: Robert Varga
> Assignee: Robert Varga
> Priority: Major
>
> As we move past Java 8, we need to look towards JPMS modules. That world is
> not supported by osgi.core/osgi.cmpn/osgi.annotation, but rather a set of
> broken-out bundles, each carrying Automatic-Module-Name. That header is
> critical to downstreams who provide module-info.java, as it provides a stable
> module name for the purposes of 'requires'.
> Convert users of 'osgi.core' using karaf-bom to use its replacements, like
> org.osgi.framework, org.osgi.util.tracker, etc.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
