dilyanpalauzov opened a new issue, #2961:
URL: https://github.com/apache/karaf/issues/2961

   According to https://github.com/apache/karaf/issues/2192 the 
META-INF/MANIFEST.MF file in a `.kar` archive serves informational purpose.
   
   However 
[kar/src/main/java/org/apache/karaf/kar/internal/Kar.java](https://github.com/apache/karaf/blob/main/kar/src/main/java/org/apache/karaf/kar/internal/Kar.java)
 contains:
   ```java
   /**
    * Representation of a Karaf Kar archive
    * 
    * A Kar archive is a jar file with a special structure that can be used
    * to deploy feature repositories, maven repo contents and resources for the
    * karaf installation.
    * 
    * meta-inf/Manifest: 
    *   Karaf-Feature-Start: (true|false) Controls if the features in the 
feature repos should be started on deploy
    *   Karaf-Feature-Repos: (uri)* If present then only the given feature repo 
urls are added to karaf if it is not
    *      present then the karaf file is scanned for repo files
    *      
    * repository/
    *   Everything below this directory is treated as a maven repository. On 
deploy the contents
    *   will be copied to a directory below data. This directory will then be 
added to the 
    *   maven repos of pax url maven
    *   
    * resource/
    *   Everything below this directory will be copied to the karaf base dir on 
deploy
    * 
    */
   ```
   
   and on the karaf console `kar:create repoName [features]` puts in 
`.kar/META-INF/MANIFEST.MF`:
   ```
   Manifest-Version: 1.0
   Karaf-Feature-Start: false
   Karaf-Feature-Repos: mvn:…features
   ```
   
   https://karaf.apache.org/manual/latest/kar says a `.kar` file is a zip 
archive, so does not need MANIFEST.MF, but the above comment defines how to 
interpret MANIFEST.MF.  As the line `Karaf-Feature-Repos` line states `if 
present` and the line `Karaf-Feature-Start` does not say so, this implies that 
`Karaf-Feature-Start` must be present.
   
   * Amend to https://karaf.apache.org/manual/latest/kar to state what a 
META-INF/MANIFEST.MF file in a `.kar` file does and state explicitly if 
MANIFEST.MF can be missing.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to