turbaszek commented on pull request #74:
URL: https://github.com/apache/kibble/pull/74#issuecomment-717345883
> > @skekre98 would you mind refactoring `kibble/setup/setup.py` so it uses
this config for default values?
>
> Could you elaborate on this a bit? Are you looking for me to refactor
`get_parser` and return an instance of KibbleConfigParser?
Once we have configuration file for Kibble we should use it in the
application:
1. create instance of Kibble config `config = KibbleConfigParser()`
2. use it as `config.get("section", "key")` for default values in
https://github.com/apache/kibble/blob/d7f9031dfd93a2efd676fcbd59443feec01df6ed/kibble/setup/setup.py#L43-L54
This will also required some refactor of the setup script + docker-compose
to be sure it works.
Let me know if you would like to try do this or should we merge this PR as
it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
