[GitHub] [kibble] turbaszek commented on a change in pull request #91: Kibble initial cli

[GitBox]

turbaszek commented on a change in pull request #91:
URL: https://github.com/apache/kibble/pull/91#discussion_r523443244



##########
File path: kibble/__main__.py
##########
@@ -15,9 +15,83 @@
 # specific language governing permissions and limitations
 # under the License.
 
+import click
+
+from kibble.cli import setup_command
+from kibble.version import version as kv
+
+from kibble.configuration import conf
+
+
+@click.group()
+def cli():
+    """A simple command line tool for kibble"""
+
+
+@cli.command("version", short_help="displays the current kibble version")
+def version():
+    click.echo(kv)
+
+
+@cli.command("setup", short_help="starts the setup process for kibble")
+@click.option(
+    "-u",
+    "--uri",
+    default=conf.get("elasticsearch", "conn_uri"),
+    help="Connection uri for ElasticSearch.",
+)
+@click.option(
+    "-d",
+    "--dbname",
+    default=conf.get("elasticsearch", "dbname"),
+    help="Pre-defined Database prefix.",
+)
+@click.option(
+    "-s",
+    "--shards",
+    default=conf.get("elasticsearch", "shards"),
+    help="Predefined number of ES shards.",
+)
+@click.option(
+    "-r",
+    "--replicas",
+    default=conf.get("elasticsearch", "replicas"),
+    help="Predefined number of replicas for ES.",
+)
+@click.option(
+    "-m",
+    "--mailhost",
+    default=conf.get("mail", "mailhost"),
+    help="Pre-defined mail server host.",
+)
+@click.option(
+    "-a", "--autoadmin", default=False, help="Generate generic admin account."
+)
+@click.option(
+    "-k", "--skiponexist", default=True, help="Skip DB creation if DBs exist."

Review comment:
       ```suggestion
       "-k", "--skiponexist", default=True, help="skip DB creation if DBs exist"
   ```
   should we standardise each help message to start with lower-case letter and 
finished without dot?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org