[ 
https://issues.apache.org/jira/browse/KUDU-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Matthew Jacobs resolved KUDU-1870.
----------------------------------
       Resolution: Fixed
    Fix Version/s: 1.3.0


commit 3e659dcd914adfbdc544b083dfd1e0686b9018c4
Author: Matthew Jacobs <m...@cloudera.com>
Date:   Mon Feb 13 14:33:06 2017 -0800

    KUDU-1870: Fix Boost build to respect CC/CXX
    
    Boost doesn't respect the CC/CXX environment variables, but
    they may have been set in the Kudu build environment. This
    fixes this issue by configuring Boost's compiler using the
    CC/CXX flags if they were set.
    
    Testing:
    - Ran thirdparty build locally, including for tsan. Checked
      that gcc/clang appeared to be set appropriately.
    - Ran Impala's toolchain build with this change, verifying
      the toolchain compiler in CC/CXX was used.
    
    Change-Id: I67002e074a67a3a83b8a96167906dbffe2db9522
    Reviewed-on: http://gerrit.cloudera.org:8080/5986
    Reviewed-by: Adar Dembo <a...@cloudera.com>
    Tested-by: Kudu Jenkins
    Reviewed-by: Todd Lipcon <t...@apache.org>


> Kudu thirdparty boost build doesn't respect external compilation options
> ------------------------------------------------------------------------
>
>                 Key: KUDU-1870
>                 URL: https://issues.apache.org/jira/browse/KUDU-1870
>             Project: Kudu
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.3.0
>            Reporter: Matthew Jacobs
>            Assignee: Matthew Jacobs
>            Priority: Critical
>              Labels: impala
>             Fix For: 1.3.0
>
>
> Impala's toolchain builds Kudu using its toolchain compiler and libraries. 
> The compiler and options are set in the standard environment variables CC, 
> CXX, etc., but the boost build results in the system compiler being used. 
> However, the CFLAGS/CXXFLAGS do get picked up, so the combination is not 
> guaranteed to be supported, and Impala toolchain builds do end up failing.
> I believe the {{project-config.jam}} needs to be set for boost to pick up the 
> right compiler. It is only being set for *san builds currently (to use clang).



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to