[ 
https://issues.apache.org/jira/browse/KUDU-3243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282768#comment-17282768
 ] 

ASF subversion and git services commented on KUDU-3243:
-------------------------------------------------------

Commit 9acdc525c6816ab83ad71f25220c428792fe36ad in kudu's branch 
refs/heads/master from Bankim Bhavsar
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=9acdc52 ]

[build] KUDU-3243 Fix cmake warnings

Bunch of warnings while running cmake of the following form:

CMake Warning (dev) at
cmake-3.19/Modules/FindPackageHandleStandardArgs.cmake:272 (message):
 The package name passed to `find_package_handle_standard_args`
 (GUMBO_PARSER) does not match the name of the calling package
 (GumboParser). This can lead to problems in calling code that expects
 `find_package` result variables (e.g., `_FOUND`) to follow a certain
 pattern.
Call Stack (most recent call first):
 cmake_modules/FindGumboParser.cmake:40 (find_package_handle_standard_args)
 CMakeLists.txt:1205 (find_package)
This warning is for project developers. Use -Wno-dev to suppress it.

There is mismatch in case/naming of the packages specified in
CMakeLists.txt at the base kudu directory and the name of the
package set under individual cmake module under cmake_modules.

No functional change. Verified no cmake warnings of the form
specified above.

Change-Id: I45ad38cf16f9ec6e23eb18e849ff5a3df3ea6ddd
Reviewed-on: http://gerrit.cloudera.org:8080/17057
Reviewed-by: Alexey Serbin <aser...@cloudera.com>
Tested-by: Bankim Bhavsar <ban...@cloudera.com>


> Fix Cmake warnings |   `find_package` result variables (e.g., `_FOUND`) to 
> follow a certain  pattern.
> -----------------------------------------------------------------------------------------------------
>
>                 Key: KUDU-3243
>                 URL: https://issues.apache.org/jira/browse/KUDU-3243
>             Project: Kudu
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 1.14.0
>            Reporter: Bankim Bhavsar
>            Assignee: Bankim Bhavsar
>            Priority: Major
>
> {noformat}
> Added shared library dependency yaml: 
> /home/bankim/src/kudu/thirdparty/installed/uninstrumented/lib/libyaml-cpp.so
> CMake Warning (dev) at 
> /home/bankim/Desktop/clion-2018.3.3/bin/cmake/linux/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:272
>  (message):
>  The package name passed to `find_package_handle_standard_args`
>  (GUMBO_PARSER) does not match the name of the calling package
>  (GumboParser). This can lead to problems in calling code that expects
>  `find_package` result variables (e.g., `_FOUND`) to follow a certain
>  pattern.
> Call Stack (most recent call first):
>  cmake_modules/FindGumboParser.cmake:40 (find_package_handle_standard_args)
>  CMakeLists.txt:1205 (find_package)
> This warning is for project developers. Use -Wno-dev to suppress it.
> Added shared library dependency gumbo-parser: 
> /home/bankim/src/kudu/thirdparty/installed/uninstrumented/lib/libgumbo.so
> CMake Warning (dev) at 
> /home/bankim/Desktop/clion-2018.3.3/bin/cmake/linux/share/cmake-3.17/Modules/FindPackageHandleStandardArgs.cmake:272
>  (message):
>  The package name passed to `find_package_handle_standard_args`
>  (GUMBO_QUERY) does not match the name of the calling package (GumboQuery).
>  This can lead to problems in calling code that expects `find_package`
>  result variables (e.g., `_FOUND`) to follow a certain pattern.
> Call Stack (most recent call first):
>  cmake_modules/FindGumboQuery.cmake:40 (find_package_handle_standard_args)
>  CMakeLists.txt:1212 (find_package)
> This warning is for project developers. Use -Wno-dev to suppress it.
>  {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to