[
https://issues.apache.org/jira/browse/KUDU-3797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18103781#comment-18103781
]
ASF subversion and git services commented on KUDU-3797:
-------------------------------------------------------
Commit 5cc227930da1dc14079837121754c112a7558d72 in kudu's branch
refs/heads/master from Yan-Daojiang
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=5cc227930 ]
KUDU-3797: Show table-level on-disk size in human-readable format
This patch formats the table-level on-disk size with
HumanReadableNumBytes::ToString() so it is consistent with the per-tablet
rows. The on-disk-size limit is left as a raw value since it uses -1 to
denote "unlimited", and the row-count fields are counts rather than byte
sizes. The client-side KuduTableStatistics::ToString() path (used when
--show_tablets is not set) is intentionally left unchanged to preserve
backward compatibility.
Change-Id: I13c025957afdc637a39a7fa7237ecb6d555ae719
Reviewed-on: http://gerrit.cloudera.org:8080/24669
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Alexey Serbin <[email protected]>
> kudu table statistics: use human-readable byte format consistently for
> on-disk size
> -----------------------------------------------------------------------------------
>
> Key: KUDU-3797
> URL: https://issues.apache.org/jira/browse/KUDU-3797
> Project: Kudu
> Issue Type: Improvement
> Reporter: Daojiang Yan
> Assignee: Daojiang Yan
> Priority: Trivial
> Labels: newbie
>
> In
> [tool_action_table.cc|vscode-file://vscode-app/Applications/Visual%20Studio%20Code.app/Contents/Resources/app/out/vs/code/electron-browser/workbench/workbench.html],
> the {{GetTableStatistics}} action prints the table-level {{on_disk_size}} as
> a raw byte count via {{{}std::to_string(){}}}, while the per-tablet
> {{on_disk_size}} (printed when {{--show_tablets}} is set) uses
> {{{}HumanReadableNumBytes::ToString(){}}}. As a result, the same value can
> appear as {{on disk size: 3145728}} at the table level and {{3.0M}} in the
> tablet rows.
> The raw format was intentionally kept for backward compatibility with the
> existing {{KuduTableStatistics::ToString()}} output. This ticket tracks
> making the byte formatting consistent across both places (e.g. by using
> {{HumanReadableNumBytes::ToString()}} for the table-level fields as well, or
> otherwise reconciling the two).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
