[
https://issues.apache.org/jira/browse/KUDU-3760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18103899#comment-18103899
]
ASF subversion and git services commented on KUDU-3760:
-------------------------------------------------------
Commit 70c51312f1186a8ae9f46647160b7730123f7601 in kudu's branch
refs/heads/master from Gabriella Lotz
[ https://gitbox.apache.org/repos/asf?p=kudu.git;h=70c51312f ]
KUDU-3760 expose follower-move flag in rebalancer
The follower-move preference added for the auto-rebalancer changed the
default of TwoDimensionalGreedyAlgo's constructor to prefer follower
moves. The CLI rebalance tool default-constructs that algorithm, so it
started preferring follower moves silently, with no way to turn it off.
Add a --prefer_follower_replica_moves flag (default true, to match both
the auto-rebalancer's flag and the new constructor default)
and plumb it through to the algorithm. This keeps the current behavior
but makes it explicit and overridable from the command line.
Adds a parameterized test that runs the tool with the flag set both ways
and checks the cluster still ends up balanced.
Change-Id: I5f1b03da71b11af82f18ff9e20dcaa676b185645
Reviewed-on: http://gerrit.cloudera.org:8080/24613
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Alexey Serbin <[email protected]>
> Add explicit --prefer_follower_replica_moves flag to CLI rebalancer
> -------------------------------------------------------------------
>
> Key: KUDU-3760
> URL: https://issues.apache.org/jira/browse/KUDU-3760
> Project: Kudu
> Issue Type: Sub-task
> Reporter: Gabriella Lotz
> Assignee: Gabriella Lotz
> Priority: Major
>
> {*}File{*}:
> {{{}[src/kudu/tools/rebalancer_tool.cc](src/kudu/tools/rebalancer_tool.cc){}}},
> {{IntraLocationRunner}}
> The CLI {{kudu rebalance}} tool now silently gets
> {{prefer_follower_moves=true}} because the constructor default changed
> (because of ["avoid leader
> moves"|https://issues.apache.org/jira/browse/KUDU-3729] optimization). Add a
> flag in the tool and plumb it to {{{}TwoDimensionalGreedyAlgo{}}}'s
> constructor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
