mapleFU commented on code in PR #1846:
URL: https://github.com/apache/kvrocks/pull/1846#discussion_r1367738356
##########
src/commands/cmd_json.cc:
##########
@@ -105,13 +105,13 @@ class CommandJsonArrAppend : public Commander {
Status Execute(Server *svr, Connection *conn, std::string *output) override {
redis::Json json(svr->storage, conn->GetNamespace());
- std::vector<uint64_t> result_count;
+ std::vector<size_t> result_count;
auto s = json.ArrAppend(args_[1], args_[2], {args_.begin() + 3,
args_.end()}, &result_count);
if (!s.ok()) return {Status::RedisExecErr, s.ToString()};
*output = redis::MultiLen(result_count.size());
- for (uint64_t c : result_count) {
+ for (auto c : result_count) {
Review Comment:
I think size_t is better(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
