git-hulk commented on code in PR #1850:
URL: https://github.com/apache/kvrocks/pull/1850#discussion_r1368034101
##########
kvrocks.conf:
##########
@@ -858,4 +858,4 @@ rocksdb.write_options.memtable_insert_hint_per_batch no
rocksdb.rate_limiter_auto_tuned yes
################################ NAMESPACE
#####################################
-# namespace.test change.me
+# namespace.test change.me
Review Comment:
Can revert this change
##########
src/common/status.h:
##########
@@ -168,7 +168,7 @@ struct StringInStatusOr<T, std::enable_if_t<sizeof(T) <
sizeof(std::string)>> :
StringInStatusOr(StringInStatusOr<U>&& v) : BaseType(new
std::string(*std::move(v))) {} // NOLINT
template <typename U, typename
std::enable_if_t<!StringInStatusOr<U>::inplace, int> = 0>
StringInStatusOr(StringInStatusOr<U>&& v) // NOLINT
- : BaseType((typename StringInStatusOr<U>::BaseType &&)(std::move(v))) {}
+ : BaseType((typename StringInStatusOr<U>::BaseType&&)(std::move(v))) {}
Review Comment:
Should revert this file. It seems the different behaviors between different
versions of clang-format. For clang-format >= 14, it will add a space for type
and parameter name, but not before clang-format 14.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
